Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

speech: fixing flaky auto punctuation test #2747

Merged
merged 4 commits into from
Jan 29, 2020
Merged

speech: fixing flaky auto punctuation test #2747

merged 4 commits into from
Jan 29, 2020

Conversation

czahedi
Copy link
Contributor

@czahedi czahedi commented Jan 23, 2020

No description provided.

@czahedi czahedi requested review from nnegrey and a team as code owners January 23, 2020 21:53
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Jan 23, 2020
@czahedi czahedi added the cla: yes This human has signed the Contributor License Agreement. label Jan 23, 2020
@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@googlebot googlebot removed the cla: no This human has *not* signed the Contributor License Agreement. label Jan 23, 2020
@czahedi
Copy link
Contributor Author

czahedi commented Jan 23, 2020

Fixed my commit username for future commits, but the CLA was triggered by having the wrong name to begin with

Copy link
Contributor

@nnegrey nnegrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nnegrey
Copy link
Contributor

nnegrey commented Jan 24, 2020

@czahedi, looks like some tests are failing.

Just look at the speech ones if you have access, otherwise we can sync on Tuesday and go through this info.

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Jan 28, 2020
@czahedi czahedi added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Jan 28, 2020
@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Jan 28, 2020
@leahecole leahecole added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Jan 29, 2020
@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@nnegrey nnegrey merged commit ee73ade into master Jan 29, 2020
@nnegrey nnegrey deleted the fix-speech-test branch January 29, 2020 21:27
busunkim96 pushed a commit to busunkim96/python-speech that referenced this pull request Sep 1, 2020
…orm/python-docs-samples#2747)

* speech: fixing flaky auto punctuation test

* Fixing beta test for auto punctuation

Co-authored-by: Noah Negrey <nnegrey@users.noreply.github.com>
Co-authored-by: Leah E. Cole <6719667+leahecole@users.noreply.github.com>
busunkim96 pushed a commit to googleapis/python-speech that referenced this pull request Sep 3, 2020
…orm/python-docs-samples#2747)

* speech: fixing flaky auto punctuation test

* Fixing beta test for auto punctuation

Co-authored-by: Noah Negrey <nnegrey@users.noreply.github.com>
Co-authored-by: Leah E. Cole <6719667+leahecole@users.noreply.github.com>
telpirion pushed a commit that referenced this pull request Jan 13, 2023
* speech: fixing flaky auto punctuation test

* Fixing beta test for auto punctuation

Co-authored-by: Noah Negrey <nnegrey@users.noreply.github.com>
Co-authored-by: Leah E. Cole <6719667+leahecole@users.noreply.github.com>
dandhlee pushed a commit that referenced this pull request Feb 9, 2023
* speech: fixing flaky auto punctuation test

* Fixing beta test for auto punctuation

Co-authored-by: Noah Negrey <nnegrey@users.noreply.github.com>
Co-authored-by: Leah E. Cole <6719667+leahecole@users.noreply.github.com>
telpirion pushed a commit that referenced this pull request Mar 13, 2023
* speech: fixing flaky auto punctuation test

* Fixing beta test for auto punctuation

Co-authored-by: Noah Negrey <nnegrey@users.noreply.github.com>
Co-authored-by: Leah E. Cole <6719667+leahecole@users.noreply.github.com>
atulep pushed a commit to googleapis/google-cloud-python that referenced this pull request Apr 6, 2023
…orm/python-docs-samples#2747)

* speech: fixing flaky auto punctuation test

* Fixing beta test for auto punctuation

Co-authored-by: Noah Negrey <nnegrey@users.noreply.github.com>
Co-authored-by: Leah E. Cole <6719667+leahecole@users.noreply.github.com>
atulep pushed a commit to googleapis/google-cloud-python that referenced this pull request Apr 6, 2023
…orm/python-docs-samples#2747)

* speech: fixing flaky auto punctuation test

* Fixing beta test for auto punctuation

Co-authored-by: Noah Negrey <nnegrey@users.noreply.github.com>
Co-authored-by: Leah E. Cole <6719667+leahecole@users.noreply.github.com>
atulep pushed a commit to googleapis/google-cloud-python that referenced this pull request Apr 18, 2023
…orm/python-docs-samples#2747)

* speech: fixing flaky auto punctuation test

* Fixing beta test for auto punctuation

Co-authored-by: Noah Negrey <nnegrey@users.noreply.github.com>
Co-authored-by: Leah E. Cole <6719667+leahecole@users.noreply.github.com>
parthea pushed a commit to googleapis/google-cloud-python that referenced this pull request Oct 22, 2023
…orm/python-docs-samples#2747)

* speech: fixing flaky auto punctuation test

* Fixing beta test for auto punctuation

Co-authored-by: Noah Negrey <nnegrey@users.noreply.github.com>
Co-authored-by: Leah E. Cole <6719667+leahecole@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants