Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(storage): add support for matchGlob parameter #7728

Closed
wants to merge 5 commits into from
Closed

feat(storage): add support for matchGlob parameter #7728

wants to merge 5 commits into from

Conversation

goober
Copy link

@goober goober commented Apr 11, 2023 •
edited
Loading

This PR aims to add support for the matchGlob parameter when listing objects.
It currently only adds support for the parameter when using the http API.

Fixes #7727

@google-cla
Copy link

google-cla bot commented Apr 11, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: storage Issues related to the Cloud Storage API. labels Apr 11, 2023
@noahdietz noahdietz requested review from tritone and removed request for tritone April 11, 2023 17:10
@goober goober marked this pull request as ready for review April 12, 2023 06:54
@goober goober requested review from a team as code owners April 12, 2023 06:54
@noahdietz noahdietz requested a review from tritone April 12, 2023 16:08
tritone
tritone reviewed Apr 12, 2023
View reviewed changes
Copy link
Contributor

@tritone tritone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. We need to add this to the gRPC implementation as well, and add a case for this to the unit/integration tests. LMK if you'd like pointers on how to do this, or if you're okay with us taking care of it.

storage/http_client.go
@@ -347,6 +347,7 @@ func (c *httpStorageClient) ListObjects(ctx context.Context, bucket string, q *Q
req.EndOffset(it.query.EndOffset)
req.Versions(it.query.Versions)
req.IncludeTrailingDelimiter(it.query.IncludeTrailingDelimiter)
req.MatchGlob(it.query.MatchGlob)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll also need to add this to the other interface implementation in grpc_client.go

@goober
Copy link
Author

goober commented Apr 12, 2023 •
edited
Loading

Thank you @tritone. It does not matter for me if you take it from here or if I update the PR with necessary changes. However, I have not looked into where to find any documentation around the gRPC api, and if the parameter is available there, so some pointers would be great.

@product-auto-label product-auto-label bot added the stale: old Pull request is old and needs attention. label May 12, 2023
@product-auto-label product-auto-label bot added stale: extraold Pull request is critically old and needs prioritization. and removed stale: old Pull request is old and needs attention. labels Jun 11, 2023
tritone added a commit to tritone/google-cloud-go that referenced this pull request Jun 15, 2023
@tritone
feat(storage): add support for MatchGlob
3d34af2 
Adds support for MatchGlob in listing objects. Only JSON is
supported because the parameter is not yet available via the
gRPC API.

Updates googleapis#7727

Supercedes googleapis#7728
tritone added a commit to tritone/google-cloud-go that referenced this pull request Jun 15, 2023
@tritone
feat(storage): add support for MatchGlob
9a371bc 
Adds support for MatchGlob in listing objects. Only JSON is
supported because the parameter is not yet available via the
gRPC API.

Updates googleapis#7727

Supercedes googleapis#7728
tritone added a commit to tritone/google-cloud-go that referenced this pull request Jun 15, 2023
@tritone
feat(storage): add support for MatchGlob
92e6f84 
Adds support for MatchGlob in listing objects. Only JSON is
supported because the parameter is not yet available via the
gRPC API.

Updates googleapis#7727

Supercedes googleapis#7728
@tritone tritone mentioned this pull request Jun 15, 2023
Merged
@tritone
Copy link
Contributor

tritone commented Jun 15, 2023

Apologies for the delay. Closing this in favor of #8097 which has the necessary testing etc.

@tritone tritone closed this Jun 15, 2023
gcf-merge-on-green bot pushed a commit that referenced this pull request Jun 21, 2023
@tritone
feat(storage): add support for MatchGlob (#8097)
9426a5a 
Adds support for MatchGlob in listing objects. Only JSON is supported because the parameter is not yet available via the gRPC API.

Updates #7727

Supercedes #7728
@release-please release-please bot mentioned this pull request Jun 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tritone tritone tritone left review comments

Assignees
No one assigned
Labels
api: storage Issues related to the Cloud Storage API. size: xs Pull request size is extra small. stale: extraold Pull request is critically old and needs prioritization.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

storage: add support for matchGlob
2 participants
@goober @tritone