Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

storage: add support for matchGlob #7727

Closed
goober opened this issue Apr 11, 2023 · 2 comments
Closed

storage: add support for matchGlob #7727

goober opened this issue Apr 11, 2023 · 2 comments
Assignees
@tritone
Labels
api: storage Issues related to the Cloud Storage API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@goober
Copy link

goober commented Apr 11, 2023

Is your feature request related to a problem? Please describe.
Support for the matchGlob parameter when listing objects in a bucket is not available from the SDK.

Describe the solution you'd like
Add an attribute to the storage.Query struct to be able to provide a glob pattern to match.

Describe alternatives you've considered
The alternative is to use the JSON API directly, which works, but then you need to handle all the boilerplate with headers and authentication etc. by your self.
@goober goober added the triage me I really want to be triaged. label Apr 11, 2023
@product-auto-label product-auto-label bot added the api: storage Issues related to the Cloud Storage API. label Apr 11, 2023
@goober goober mentioned this issue Apr 11, 2023
Closed
@noahdietz noahdietz added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. and removed triage me I really want to be triaged. labels Apr 11, 2023
@tritone
Copy link
Contributor

tritone commented Apr 12, 2023

Thanks for the PR -- we had this in our backlog for this quarter anyway. I left some comments, we can work with you on the PR or finish it off ourselves.

tritone added a commit to tritone/google-cloud-go that referenced this issue Jun 15, 2023
@tritone
feat(storage): add support for MatchGlob
3d34af2 
Adds support for MatchGlob in listing objects. Only JSON is
supported because the parameter is not yet available via the
gRPC API.

Updates googleapis#7727

Supercedes googleapis#7728
tritone added a commit to tritone/google-cloud-go that referenced this issue Jun 15, 2023
@tritone
feat(storage): add support for MatchGlob
9a371bc 
Adds support for MatchGlob in listing objects. Only JSON is
supported because the parameter is not yet available via the
gRPC API.

Updates googleapis#7727

Supercedes googleapis#7728
tritone added a commit to tritone/google-cloud-go that referenced this issue Jun 15, 2023
@tritone
feat(storage): add support for MatchGlob
92e6f84 
Adds support for MatchGlob in listing objects. Only JSON is
supported because the parameter is not yet available via the
gRPC API.

Updates googleapis#7727

Supercedes googleapis#7728
@tritone tritone mentioned this issue Jun 15, 2023
Merged
gcf-merge-on-green bot pushed a commit that referenced this issue Jun 21, 2023
@tritone
feat(storage): add support for MatchGlob (#8097)
9426a5a 
Adds support for MatchGlob in listing objects. Only JSON is supported because the parameter is not yet available via the gRPC API.

Updates #7727

Supercedes #7728
@release-please release-please bot mentioned this issue Jun 21, 2023
Merged
@tritone tritone mentioned this issue Sep 27, 2023
Merged
1 task
@goober
Copy link
Author

goober commented Oct 3, 2023

Fixed by #8618

@goober goober closed this as completed Oct 3, 2023
tritone added a commit to tritone/google-cloud-go that referenced this issue Oct 11, 2023
@tritone
feat(storage): support MatchGlob for gRPC
6909a10 
Updates googleapis#7727
tritone added a commit to tritone/google-cloud-go that referenced this issue Oct 11, 2023
@tritone
feat(storage): support MatchGlob for gRPC
f65151f 
Updates googleapis#7727
@tritone tritone mentioned this issue Oct 11, 2023
Merged
gcf-merge-on-green bot pushed a commit that referenced this issue Oct 16, 2023
@tritone
feat(storage): support MatchGlob for gRPC (#8670)
3df0287 
Updates #7727
@release-please release-please bot mentioned this issue Oct 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tritone tritone

Labels
api: storage Issues related to the Cloud Storage API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(storage): add support for matchGlob parameter goober/google-cloud-go
3 participants
@goober @tritone @noahdietz