-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(mixin): add manual changes for pubsub and generate mixin code #14756
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all looks good. What is the testing plan though?
Unit testing
I think we want golden unit tests, at least in the stub that verifies that the mixin StubInterface
is used, not the service's.
It looks like there is a way to define our own *.yaml
for the golden files.
override_service_config_yaml_name: "generator/integration_tests/test_request_id.yaml" |
Then we would add a unit test here:
https://github.com/googleapis/google-cloud-cpp/tree/main/generator/integration_tests/tests
Integration Testing
I think we also need an integration test that proves that these APIs work against production. We typically use spanner's admin APIs for integration testing the generator.
It looks like we can eventually have something for the LRO mixin.
Also, this API is now obsolete:
google-cloud-cpp/google/cloud/pubsub/options.h
Lines 415 to 429 in a695357
/** | |
* Convenience function to initialize a | |
* `google::cloud::iam::IAMPolicyConnection`. | |
* | |
* To manage the IAM policies of Pub/Sub resources you need to configure the | |
* `google::cloud::IAMPolicyClient` to use `pubsub.googleapis.com` as the | |
* `google::cloud::EndpointOption` and `google::cloud::AuthorityOption`. | |
* | |
* This function returns an object that is initialized with these values, you | |
* can provide additional configuration, or override some of the values before | |
* passing the object to `google::cloud::iam::MakeIAMPolicyConnection`. | |
* | |
* @ingroup google-cloud-pubsub-options | |
*/ | |
Options IAMPolicyOptions(Options opts = {}); |
We should deprecate it, and recommend that applications use the new mixed-in APIs. Can you open an issue?
I created an issue for adding tests for mixin. |
This change is