-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support google.cloud.location.Locations
and maybe other mixins
#11694
Closed
Labels
cpp: generator
Issues related to the C++ micro-generator
type: feature request
‘Nice-to-have’ improvement, new feature or different behavior or design.
Comments
coryan
added
type: feature request
‘Nice-to-have’ improvement, new feature or different behavior or design.
cpp: generator
Issues related to the C++ micro-generator
labels
May 22, 2023
We should do this, but needs some design. |
Still want to do this as part of other improvements to generated libraries. |
Design:
Submit:
|
This was
linked to
pull requests
Sep 25, 2024
This was
linked to
pull requests
Oct 4, 2024
The mixin is done. There is a followup issue #14762 to add tests for mixin. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cpp: generator
Issues related to the C++ micro-generator
type: feature request
‘Nice-to-have’ improvement, new feature or different behavior or design.
A number of services include the
Locations
mixin:https://github.com/googleapis/googleapis/blob/117be9dfdf65ff766a794c8b85d5d7480a1fd83d/google/cloud/location/locations.proto#L29-L32
These mixins do not appear in the
.proto
file, they only seem to appear in the YAML file:https://github.com/googleapis/googleapis/blob/117be9dfdf65ff766a794c8b85d5d7480a1fd83d/google/cloud/clouddms/v1/datamigration_v1.yaml#L6-L10
But they are part of the service and included in the API configuration:
https://cloud.google.com/database-migration/docs/reference/rest/v1/projects.locations
https://cloud.google.com/kms/docs/reference/rpc/google.cloud.location
I think the generator needs to support these. It is unclear if these methods should be part of the
*Client
, or there should be a commongoogle::cloud::LocationClient
with suitable endpoint defaults. Or some other solution. The first step is to write some kind of design doc.The text was updated successfully, but these errors were encountered: