Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup(generator): no need for exceptions #ifdef #13611

Merged

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Feb 14, 2024

This change is Reviewable

@coryan coryan marked this pull request as ready for review February 14, 2024 16:33
@coryan coryan requested a review from a team as a code owner February 14, 2024 16:33
Copy link

codecov bot commented Feb 14, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (f5caade) 93.16% compared to head (63af35f) 93.16%.

Files Patch % Lines
generator/internal/printer.h 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13611      +/-   ##
==========================================
- Coverage   93.16%   93.16%   -0.01%     
==========================================
  Files        2221     2221              
  Lines      192914   192913       -1     
==========================================
- Hits       179732   179731       -1     
  Misses      13182    13182              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coryan coryan merged commit 2d2a391 into googleapis:main Feb 14, 2024
60 of 61 checks passed
@coryan coryan deleted the cleanup-generator-we-always-need-exceptions branch February 14, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants