impl(generator): request_id-like helpers
#13605
Conversation
Add some functions to determine if a method has at least one `request_id`-like field, i.e., a non-repeating string field in the request message that expects UUIDV4 values.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #13605 +/- ##
========================================
Coverage 93.17% 93.17%
========================================
Files 2221 2223 +2
Lines 192897 192998 +101
========================================
+ Hits 179723 179819 +96
- Misses 13174 13179 +5 ☔ View full report in Codecov by Sentry. |
|
|
||
| std::string RequestIdFieldName( | ||
| YAML::Node const& service_config, | ||
| google::protobuf::MethodDescriptor const& descriptor) try { |
There was a problem hiding this comment.
Do we need #if GOOGLE_CLOUD_CPP_HAVE_EXCEPTIONS protecting exception code?
There was a problem hiding this comment.
I don't think so. I have included an item for discussion in today's meeting, in case somebody has a reason to support builds without exceptions I have not thought of.
Basically the generator needs to compile on a limited number of builds (*San builds, clang-tidy builds, and the builds that use it). Running without exception support is not a requirement.
There was a problem hiding this comment.
Sounds good to me, but then we should probably remove the conditionals from generator/internal/printer.h.
Add some functions to determine if a method has at least one
request_id-like field, i.e., a non-repeating string field in the request message that expects UUIDV4 values.Part of the work for #13595
This change is