Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(spanner): samples for bit-reversed sequence #12280

Merged
merged 1 commit into from
Aug 1, 2023

Conversation

devbww
Copy link
Contributor

@devbww devbww commented Aug 1, 2023

Bit-Reversed Sequence provides a way for Cloud Spanner to automatically generate hotspot-proof, unique 64-bit values for primary key columns. Manually bit-reversing monotonic key values is now recommended as a best practice.


This change is Reviewable

Bit-Reversed Sequence provides a way for Cloud Spanner to automatically
generate hotspot-proof, unique 64-bit values for primary key columns.
Manually bit-reversing monotonic key values is now recommended as a best
practice.
@devbww devbww temporarily deployed to internal August 1, 2023 07:49 — with GitHub Actions Inactive
@product-auto-label product-auto-label bot added api: spanner Issues related to the Spanner API. samples Issues that are directly related to samples. labels Aug 1, 2023
@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Patch coverage: 0.70% and project coverage change: -0.08% ⚠️

Comparison is base (8cb3165) 93.62% compared to head (3dcc269) 93.55%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12280      +/-   ##
==========================================
- Coverage   93.62%   93.55%   -0.08%     
==========================================
  Files        2009     2009              
  Lines      177410   177552     +142     
==========================================
+ Hits       166104   166109       +5     
- Misses      11306    11443     +137     
Files Changed Coverage Δ
google/cloud/spanner/samples/postgresql_samples.cc 0.59% <0.00%> (-0.07%) ⬇️
google/cloud/spanner/samples/samples.cc 59.39% <1.31%> (-1.65%) ⬇️

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@devbww devbww marked this pull request as ready for review August 1, 2023 08:30
@devbww devbww requested a review from a team as a code owner August 1, 2023 08:30
@snippet-bot
Copy link

snippet-bot bot commented Aug 1, 2023

Here is the summary of changes.

You are about to add 6 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@devbww devbww merged commit d1b9d94 into googleapis:main Aug 1, 2023
@devbww devbww deleted the bit-reversed-sequence branch August 1, 2023 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the Spanner API. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants