Skip to content
This repository has been archived by the owner on Jun 28, 2022. It is now read-only.

Drop "non_empty = True" to fix a bazel error. #2885

Merged
merged 3 commits into from
Aug 2, 2019

Conversation

g-easy
Copy link
Contributor

@g-easy g-easy commented Jul 24, 2019

This change is needed to fix a build-time error that started happening with
bazel version 0.27.

See also: bazelbuild/bazel#5818

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 24, 2019
@codecov
Copy link

codecov bot commented Jul 24, 2019

Codecov Report

Merging #2885 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2885   +/-   ##
=========================================
  Coverage     87.34%   87.34%           
  Complexity     5853     5853           
=========================================
  Files           477      477           
  Lines         23223    23223           
  Branches       2507     2507           
=========================================
  Hits          20284    20284           
  Misses         2100     2100           
  Partials        839      839

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4a823d...572fcfb. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jul 24, 2019

Codecov Report

Merging #2885 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2885   +/-   ##
=========================================
  Coverage     87.34%   87.34%           
  Complexity     5853     5853           
=========================================
  Files           477      477           
  Lines         23223    23223           
  Branches       2507     2507           
=========================================
  Hits          20284    20284           
  Misses         2100     2100           
  Partials        839      839

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4a823d...572fcfb. Read the comment docs.

@codecov
Copy link

codecov bot commented Jul 24, 2019

Codecov Report

Merging #2885 into master will increase coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2885      +/-   ##
============================================
+ Coverage     87.24%   87.34%   +0.09%     
- Complexity     5824     5853      +29     
============================================
  Files           476      477       +1     
  Lines         23045    23223     +178     
  Branches       2493     2507      +14     
============================================
+ Hits          20106    20284     +178     
+ Misses         2101     2100       -1     
- Partials        838      839       +1
Impacted Files Coverage Δ Complexity Δ
...en/transformer/php/PhpGapicSamplesTransformer.java 95.71% <0%> (-4.29%) 12% <0%> (+5%)
...le/api/codegen/transformer/SampleFileRegistry.java 71.21% <0%> (-4.14%) 9% <0%> (-1%)
...codegen/transformer/nodejs/NodeJSSurfaceNamer.java 88.42% <0%> (-0.42%) 97% <0%> (-1%)
...m/google/api/codegen/transformer/SurfaceNamer.java 72.76% <0%> (-0.14%) 210% <0%> (-3%)
.../com/google/api/codegen/viewmodel/CallingForm.java 96.52% <0%> (-0.08%) 5% <0%> (ø)
...n/transformer/DynamicLangApiMethodTransformer.java 99.34% <0%> (-0.02%) 33% <0%> (-1%)
...egen/transformer/go/GoGapicSurfaceTransformer.java 100% <0%> (ø) 41% <0%> (ø) ⬇️
.../transformer/py/PythonGapicSamplesTransformer.java 100% <0%> (ø) 20% <0%> (+15%) ⬆️
.../transformer/ruby/RubyGapicSamplesTransformer.java 100% <0%> (ø) 23% <0%> (+19%) ⬆️
...nsformer/nodejs/NodeJSGapicSurfaceTransformer.java 100% <0%> (ø) 27% <0%> (ø) ⬇️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 110ecfe...c4e9948. Read the comment docs.

Copy link
Contributor

@vam-google vam-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please specify in PR description why it had to be done and from which bazel vertion this started to fail.

Thanks!

@g-easy
Copy link
Contributor Author

g-easy commented Aug 1, 2019

Done.

The error looks like:

File ".../external/com_google_api_codegen/rules_gapic/php/php_gapic_pkg.bzl", line 59
		rule(attrs = {"deps": attr.label_list...)}, <2 more arguments>)
	File ".../external/com_google_api_codegen/rules_gapic/php/php_gapic_pkg.bzl", line 61, in rule
		attr.label_list(allow_files = True, mandatory = Tr..., ...)
'non_empty' is no longer supported. use allow_empty instead. You can use --incompatible_disable_deprecated_attr_params=false to temporarily disable this check.

@vam-google vam-google merged commit 71fd9b5 into googleapis:master Aug 2, 2019
busunkim96 pushed a commit to busunkim96/gapic-generator that referenced this pull request Nov 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants