-
Notifications
You must be signed in to change notification settings - Fork 129
Drop "non_empty = True" to fix a bazel error. #2885
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2885 +/- ##
=========================================
Coverage 87.34% 87.34%
Complexity 5853 5853
=========================================
Files 477 477
Lines 23223 23223
Branches 2507 2507
=========================================
Hits 20284 20284
Misses 2100 2100
Partials 839 839 Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #2885 +/- ##
=========================================
Coverage 87.34% 87.34%
Complexity 5853 5853
=========================================
Files 477 477
Lines 23223 23223
Branches 2507 2507
=========================================
Hits 20284 20284
Misses 2100 2100
Partials 839 839 Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #2885 +/- ##
============================================
+ Coverage 87.24% 87.34% +0.09%
- Complexity 5824 5853 +29
============================================
Files 476 477 +1
Lines 23045 23223 +178
Branches 2493 2507 +14
============================================
+ Hits 20106 20284 +178
+ Misses 2101 2100 -1
- Partials 838 839 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, please specify in PR description why it had to be done and from which bazel vertion this started to fail.
Thanks!
Done. The error looks like:
|
This change is needed to fix a build-time error that started happening with
bazel version 0.27.
See also: bazelbuild/bazel#5818