Skip to content

Commit

Permalink
Drop "non_empty = True" to fix a bazel error. (googleapis#2885)
Browse files Browse the repository at this point in the history
  • Loading branch information
g-easy authored and busunkim96 committed Nov 7, 2019
1 parent 46072de commit 2ea978f
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion rules_gapic/go/go_gapic_pkg.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ def _go_gapic_src_pkg_impl(ctx):

_go_gapic_src_pkg = rule(
attrs = {
"deps": attr.label_list(allow_files = True, mandatory = True, non_empty = True),
"deps": attr.label_list(allow_files = True, mandatory = True),
"package_dir": attr.string(mandatory = True),
},
outputs = {"pkg": "%{name}.tar.gz"},
Expand Down
4 changes: 2 additions & 2 deletions rules_gapic/java/java_gapic_pkg.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ def _java_gapic_build_configs_pkg_impl(ctx):

java_gapic_build_configs_pkg = rule(
attrs = {
"deps": attr.label_list(mandatory = True, non_empty = True),
"deps": attr.label_list(mandatory = True),
"test_deps": attr.label_list(mandatory = False, allow_empty = True),
"package_dir": attr.string(mandatory = False),
"artifact_group_overrides": attr.string_dict(mandatory = False, allow_empty = True, default = {}),
Expand Down Expand Up @@ -153,7 +153,7 @@ def _java_gapic_srcs_pkg_impl(ctx):

java_gapic_srcs_pkg = rule(
attrs = {
"deps": attr.label_list(mandatory = True, non_empty = True),
"deps": attr.label_list(mandatory = True),
"test_deps": attr.label_list(mandatory = False, allow_empty = True),
"package_dir": attr.string(mandatory = True),
},
Expand Down
2 changes: 1 addition & 1 deletion rules_gapic/nodejs/nodejs_gapic_pkg.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ def _nodejs_gapic_src_pkg_impl(ctx):

_nodejs_gapic_src_pkg = rule(
attrs = {
"deps": attr.label_list(allow_files = True, mandatory = True, non_empty = True),
"deps": attr.label_list(allow_files = True, mandatory = True),
"package_dir": attr.string(mandatory = True),
},
outputs = {"pkg": "%{name}.tar.gz"},
Expand Down
2 changes: 1 addition & 1 deletion rules_gapic/php/php_gapic_pkg.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ def _php_gapic_src_pkg_impl(ctx):

_php_gapic_src_pkg = rule(
attrs = {
"deps": attr.label_list(allow_files = True, mandatory = True, non_empty = True),
"deps": attr.label_list(allow_files = True, mandatory = True),
"package_dir": attr.string(mandatory = True),
},
outputs = {"pkg": "%{name}.tar.gz"},
Expand Down

0 comments on commit 2ea978f

Please sign in to comment.