test: use unittest.mock #1320
Merged
test: use unittest.mock #1320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hroncok
reviewed
May 19, 2022
gapic/ads-templates/tests/unit/gapic/%name_%version/%sub/test_%service.py.j2
Outdated
Show resolved
Hide resolved
gapic/templates/tests/unit/gapic/%name_%version/%sub/test_%service.py.j2
Outdated
Show resolved
Hide resolved
tests/integration/goldens/asset/tests/unit/gapic/asset_v1/test_asset_service.py
Outdated
Show resolved
Hide resolved
tests/integration/goldens/credentials/tests/unit/gapic/credentials_v1/test_iam_credentials.py
Outdated
Show resolved
Hide resolved
tests/integration/goldens/eventarc/tests/unit/gapic/eventarc_v1/test_eventarc.py
Outdated
Show resolved
Hide resolved
595b0a6 to
4c55fac
Compare
atulep
reviewed
May 20, 2022
atulep
approved these changes
May 20, 2022
This was referenced May 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mockis deprecated and it’s recommended to useunittest.mock.unittest.mockis available from python 3.3.unittest.mock.AsyncMockis only available from python 3.8+ so we need to use theasyncmockpackage for python<3.8Fixes googleapis/python-bigquery-connection#212
Fixes googleapis/python-security-private-ca#231
Fixes googleapis/python-billing#182
Fixes googleapis/python-bigquery-reservation#267
Fixes googleapis/python-deploy#75
Fixes googleapis/python-firestore#576
Fixes googleapis/python-dlp#389
Fixes googleapis/python-asset#427