Skip to content
This repository has been archived by the owner on Feb 28, 2024. It is now read-only.

Use unittest.mock if available instead of the deprecated mock module #427

Closed
major opened this issue May 19, 2022 · 0 comments · Fixed by googleapis/gapic-generator-python#1320
Closed

Use unittest.mock if available instead of the deprecated mock module #427

major opened this issue May 19, 2022 · 0 comments · Fixed by googleapis/gapic-generator-python#1320
Assignees
@parthea
Labels
api: cloudasset Issues related to the googleapis/python-asset API. type: cleanup An internal cleanup or hygiene concern.

Comments

@major
Copy link

major commented May 19, 2022

Environment details

  • OS type and version: Fedora 36
  • Python version: 3.10.4
  • pip version: 22.0.4
  • google-cloud-asset version: main branch

Steps to reproduce

  1. Run tests on Python 3.10 without mock installed
  2. Tests fail to run

I'll propose a PR to fix this in a moment.
@product-auto-label product-auto-label bot added the api: cloudasset Issues related to the googleapis/python-asset API. label May 19, 2022
@major major mentioned this issue May 19, 2022
Closed
@parthea parthea added the type: cleanup An internal cleanup or hygiene concern. label May 19, 2022
@parthea parthea mentioned this issue May 20, 2022
Merged
@parthea parthea self-assigned this May 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@parthea parthea

Labels
api: cloudasset Issues related to the googleapis/python-asset API. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
2 participants
@major @parthea