-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix resource path args for paths with =** #1089
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
This human has signed the Contributor License Agreement.
label
Nov 17, 2021
busunkim96
changed the title
fix(snippetgen): fix resource path args for paths with =**
fix: fix resource path args for paths with =**
Nov 17, 2021
busunkim96
commented
Nov 17, 2021
@@ -110,7 +110,7 @@ class TransformedRequest: | |||
|
|||
# Resource patterns look something like | |||
# kingdom/{kingdom}/phylum/{phylum}/class/{class} | |||
RESOURCE_RE = re.compile(r"\{([^}/]+)\}") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This regex seemed to be serving the same purpose as the one in wrappers.py
tseaver
approved these changes
Nov 17, 2021
software-dov
approved these changes
Nov 17, 2021
busunkim96
added
the
automerge
Merge the pull request once unit tests and other checks pass.
label
Nov 18, 2021
busunkim96
removed
the
automerge
Merge the pull request once unit tests and other checks pass.
label
Nov 18, 2021
busunkim96
added
the
automerge
Merge the pull request once unit tests and other checks pass.
label
Nov 18, 2021
gcf-merge-on-green
bot
removed
the
automerge
Merge the pull request once unit tests and other checks pass.
label
Nov 18, 2021
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Dec 8, 2021
🤖 I have created a release \*beep\* \*boop\* --- ## [0.58.0](https://www.github.com/googleapis/gapic-generator-python/compare/v0.57.0...v0.58.0) (2021-12-07) ### Features * add support for long-running operations with rest transport. ([#1094](https://www.github.com/googleapis/gapic-generator-python/issues/1094)) ([e89fd23](https://www.github.com/googleapis/gapic-generator-python/commit/e89fd23609625c5aa49acd6c6ee67f87fce324fd)) ### Bug Fixes * ensure rest unit tests have complete coverage ([#1098](https://www.github.com/googleapis/gapic-generator-python/issues/1098)) ([0705d9c](https://www.github.com/googleapis/gapic-generator-python/commit/0705d9c5dbbea793867551e64991be37d8339c6b)) * fix resource path args for paths with =** ([#1089](https://www.github.com/googleapis/gapic-generator-python/issues/1089)) ([309cc66](https://www.github.com/googleapis/gapic-generator-python/commit/309cc66e880e07940866864b03c744310ef56762)) * **snippetgen:** don't create duplicate requests for required oneofs ([#1088](https://www.github.com/googleapis/gapic-generator-python/issues/1088)) ([5531795](https://www.github.com/googleapis/gapic-generator-python/commit/55317956397370a91b1a06ecd476e55f58789807)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This was referenced Jan 18, 2022
This was referenced Jan 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some resources have
=**
in the segment. . A segment with=**
is not matched by the current regex:This pattern shows up in the some real APIs (monitoring protos,
google/cloud/iap/v1
,google/cloud/iap/v1beta1
,google/cloud/recommendationengine/v1beta1
,google/devtools/remoteworkers/v1test2
,google/home/graph/v1
,google/iam/v1
).**
is mentioned in passing in Resource Names. I was not able to find an explanation of what wildcards are considered valid in https://google.aip.dev/122 or https://google.aip.dev/client-libraries/4231.Monitoring Proto Example: