Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: release 0.58.0 #1097

Merged
merged 1 commit into from
Dec 8, 2021
Merged

chore: release 0.58.0 #1097

merged 1 commit into from
Dec 8, 2021

Conversation

release-please[bot]
Copy link
Contributor

@release-please release-please bot commented Nov 25, 2021 •
edited
Loading

🤖 I have created a release *beep* *boop*

0.58.0 (2021-12-07)

Features

  • add support for long-running operations with rest transport. (#1094) (e89fd23)

Bug Fixes

  • ensure rest unit tests have complete coverage (#1098) (0705d9c)
  • fix resource path args for paths with =** (#1089) (309cc66)
  • snippetgen: don't create duplicate requests for required oneofs (#1088) (5531795)

This PR was generated with Release Please. See documentation.

@release-please release-please bot requested review from a team as code owners November 25, 2021 02:19
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 25, 2021
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Nov 25, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 25, 2021
@release-please release-please bot requested a review from a team as a code owner December 2, 2021 10:34
@trusted-contributions-gcf trusted-contributions-gcf bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 2, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 2, 2021
@trusted-contributions-gcf trusted-contributions-gcf bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 2, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 2, 2021
vam-google
vam-google approved these changes Dec 7, 2021
View reviewed changes
Copy link
Contributor

@vam-google vam-google left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
[edit] Please read the other comment

vam-google
vam-google suggested changes Dec 7, 2021
View reviewed changes
Copy link
Contributor

@vam-google vam-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please wait for the core artifacts with extended_operatoions to be published first. After those are published we need to remove extended_operations from gapic-generator-python, make it depend on new version of common protos and only then release.

@hkdevandla
Copy link
Member

LGTM - based on the release notes and assumption that changes are specific to DIREGAPIC or specific feature set but doesn't impact the overall client libraries.

@trusted-contributions-gcf trusted-contributions-gcf bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 7, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 7, 2021
@parthea parthea requested a review from vam-google December 7, 2021 23:22
vam-google
vam-google approved these changes Dec 7, 2021
View reviewed changes
Copy link
Contributor

@vam-google vam-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@parthea parthea added the automerge Merge the pull request once unit tests and other checks pass. label Dec 8, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit 6d78f5e into master Dec 8, 2021
@gcf-merge-on-green gcf-merge-on-green bot deleted the release-v0.58.0 branch December 8, 2021 15:06
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Dec 8, 2021
@yoshi-automation
Copy link

Release is at https://github.com/googleapis/gapic-generator-python/releases/tag/v0.58.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vam-google vam-google vam-google approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement. kokoro:force-run Add this label to force Kokoro to re-run the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hkdevandla @yoshi-automation @vam-google @parthea