Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: drop support for node 4 and 9 #780

Merged
merged 1 commit into from
Jul 9, 2018
Merged

chore: drop support for node 4 and 9 #780

merged 1 commit into from
Jul 9, 2018

Conversation

kjin
Copy link
Contributor

@kjin kjin commented Jun 20, 2018 •
edited
Loading

BREAKING CHANGE: This change drops support for Node 4 and 9.

r-i-t-m needs to be fixed at 2.2.1. Tracking this at #779.

Actually, I do not want this to land yet.

@kjin kjin requested a review from a team June 20, 2018 00:54
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 20, 2018
ofrobots
ofrobots reviewed Jun 20, 2018
View reviewed changes
Copy link
Contributor

@ofrobots ofrobots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • update the package.json engines field.
  • Make this commit and PR as semver-major.

@kjin kjin added the semver: major Hint for users that this is an API breaking change. label Jun 20, 2018
@kjin kjin changed the title chore: stop running ci for node 4 and 9 chore: drop support for node 4 and 9 Jun 20, 2018
@kjin
Copy link
Contributor Author

kjin commented Jun 20, 2018

@ofrobots Done

@kjin kjin added the status: blocked Resolving the issue is dependent on other work. label Jun 20, 2018
@kjin kjin mentioned this pull request Jun 20, 2018
Closed
@ofrobots
Copy link
Contributor

Depending on how long you think it would take to get the other semver major changes in in order to unblock this – it might be worthwhile to land semver majors onto a v3 branch.

@kjin
chore: drop support for node 4 and 9
12f106d 
BREAKING CHANGE: This commit drops support for Node 4 and 9.
@kjin kjin removed the status: blocked Resolving the issue is dependent on other work. label Jul 2, 2018
@kjin
Copy link
Contributor Author

kjin commented Jul 9, 2018

I will land this on master and maintain a v2.x branch.

@kjin kjin merged commit e4cfb1b into googleapis:master Jul 9, 2018
@release-please release-please bot mentioned this pull request Jun 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ofrobots ofrobots ofrobots approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement. semver: major Hint for users that this is an API breaking change.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kjin @ofrobots @googlebot