Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests fail with require-in-the-middle@2.2.2 #779

Closed
kjin opened this issue Jun 20, 2018 · 0 comments
Closed

Tests fail with require-in-the-middle@2.2.2 #779

kjin opened this issue Jun 20, 2018 · 0 comments
Assignees
@kjin
Labels
api: cloudtrace Issues related to the googleapis/cloud-trace-nodejs API. type: process A process-related concern. May include testing, release, or the like.

Comments

@kjin
Copy link
Contributor

kjin commented Jun 20, 2018 •
edited
Loading

We need to investigate whether the require-in-the-middle@2.2.2 changes are compatible with how we patch modules. For now, I am fixing the module at 2.2.1.
@kjin kjin added priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: process A process-related concern. May include testing, release, or the like. labels Jun 20, 2018
@JustinBeckwith JustinBeckwith added the triage me I really want to be triaged. label Jun 20, 2018
@kjin kjin removed the triage me I really want to be triaged. label Jun 20, 2018
@kjin kjin self-assigned this Jun 20, 2018
This was referenced Jun 20, 2018
Merged
Merged
@JustinBeckwith JustinBeckwith added 🚨 This issue needs some love. and removed 🚨 This issue needs some love. labels Jun 25, 2018
@kjin kjin mentioned this issue Jun 27, 2018
Merged
@kjin kjin closed this as completed in #789 Jun 28, 2018
@ofrobots ofrobots removed the priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. label Jun 28, 2018
@google-cloud-label-sync google-cloud-label-sync bot added the api: cloudtrace Issues related to the googleapis/cloud-trace-nodejs API. label Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kjin kjin

Labels
api: cloudtrace Issues related to the googleapis/cloud-trace-nodejs API. type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ofrobots @JustinBeckwith @kjin