-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: use synth templates and kokoro config #1062
Conversation
10f6b67
to
52695d2
Compare
cc/ @JustinBeckwith |
Codecov Report
@@ Coverage Diff @@
## master #1062 +/- ##
==========================================
- Coverage 94.86% 91.68% -3.19%
==========================================
Files 96 114 +18
Lines 6327 6611 +284
Branches 496 496
==========================================
+ Hits 6002 6061 +59
- Misses 166 391 +225
Partials 159 159
Continue to review full report at Codecov.
|
.kokoro/docs.sh
Outdated
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
|
||
set -xeo pipefail |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks like a slightly older version of config then is currently live in synthtool
. We dropped -xeo
and went with -eo
, because -x
leaks a lot of environment information.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see. I used the stable build of synthtool. Sure enough with latest the contents have now changed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll see about getting a new version of synthtool out the door.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note -- I would like to get coverage working before merging this.
64dcb4b
to
9027690
Compare
OK, I've fixed coverage. (For posterity, |
This PR brings in a workable kokoro configuration. However, code coverage reporting remains TBD.
Note that on Windows, integration (plugin) tests are not run.
Dependent on #1059, #1060, #1061; only the first two commits in this PR are unique; the rest will be erased once these PRs land.
This is meant to supersede #1049, but I'm not sure if it checks all the boxes listed there.