Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: use synth templates and kokoro config #1062

Merged
merged 2 commits into from
Jul 2, 2019
Merged

Conversation

kjin
Copy link
Contributor

@kjin kjin commented Jun 29, 2019

This PR brings in a workable kokoro configuration. However, code coverage reporting remains TBD.

Note that on Windows, integration (plugin) tests are not run.

Dependent on #1059, #1060, #1061; only the first two commits in this PR are unique; the rest will be erased once these PRs land.

This is meant to supersede #1049, but I'm not sure if it checks all the boxes listed there.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 29, 2019
@kjin kjin force-pushed the synth branch 5 times, most recently from 10f6b67 to 52695d2 Compare June 29, 2019 03:02
@kjin kjin changed the title Kokoro experiments [2] build: use synth templates and kokoro config Jun 29, 2019
@kjin kjin marked this pull request as ready for review June 29, 2019 03:05
@kjin
Copy link
Contributor Author

kjin commented Jun 29, 2019

cc/ @JustinBeckwith

@codecov
Copy link

codecov bot commented Jun 29, 2019

Codecov Report

Merging #1062 into master will decrease coverage by 3.18%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1062      +/-   ##
==========================================
- Coverage   94.86%   91.68%   -3.19%     
==========================================
  Files          96      114      +18     
  Lines        6327     6611     +284     
  Branches      496      496              
==========================================
+ Hits         6002     6061      +59     
- Misses        166      391     +225     
  Partials      159      159
Impacted Files Coverage Δ
.jsdoc.js 0% <0%> (ø)
test/plugins/test-trace-http.ts 100% <0%> (ø) ⬆️
...t/fixtures/source-maps-test/external-source-map.js 0% <0%> (ø)
test/non-interference/express-e2e.js 0% <0%> (ø)
system-test/trace-express.js 0% <0%> (ø)
samples/app.js 0% <0%> (ø)
...est/fixtures/source-maps-test/inline-source-map.js 0% <0%> (ø)
...est/fixtures/source-maps-test/inline-source-map.ts 0% <0%> (ø)
samples/snippets.js 0% <0%> (ø)
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3cfa7a0...cce9516. Read the comment docs.

.kokoro/docs.sh Outdated
# See the License for the specific language governing permissions and
# limitations under the License.

set -xeo pipefail
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks like a slightly older version of config then is currently live in synthtool. We dropped -xeo and went with -eo, because -x leaks a lot of environment information.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. I used the stable build of synthtool. Sure enough with latest the contents have now changed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll see about getting a new version of synthtool out the door.

synth.py Show resolved Hide resolved
synth.py Show resolved Hide resolved
Copy link
Contributor Author

@kjin kjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note -- I would like to get coverage working before merging this.

synth.py Show resolved Hide resolved
synth.py Show resolved Hide resolved
@kjin kjin force-pushed the synth branch 2 times, most recently from 64dcb4b to 9027690 Compare July 1, 2019 22:43
@kjin
Copy link
Contributor Author

kjin commented Jul 2, 2019

OK, I've fixed coverage. (For posterity, .nycrc needs to be ignored for now, as the Trace Agent has a script for producing per-test-file coverage rather than test-suite-wide coverage.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants