Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: use synth templates and kokoro config #1049

Closed
wants to merge 2 commits into from
Closed

Conversation

JustinBeckwith
Copy link
Contributor

@JustinBeckwith JustinBeckwith commented Jun 22, 2019

This brings in the kokoro configuration we're using for all of our other libraries, along with other common templated files.

  • blocked on getting the kokoro backend configured
  • Submit PR to land just the formatting changes
  • Submit PR to land just the formatting changes
  • Get the unit tests all passing in kokoro
  • Migrate remaining customized tests over to kokoro
  • Delete circleCI config

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 22, 2019
@codecov
Copy link

codecov bot commented Jun 22, 2019

Codecov Report

Merging #1049 into master will decrease coverage by 2.99%.
The diff coverage is 98.07%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #1049    +/-   ##
========================================
- Coverage   94.85%   91.85%    -3%     
========================================
  Files          96      110    +14     
  Lines        6311     6517   +206     
  Branches      496      496            
========================================
  Hits         5986     5986            
- Misses        166      372   +206     
  Partials      159      159
Impacted Files Coverage Δ
test/web-frameworks/restify.ts 88.23% <ø> (ø) ⬆️
src/plugins/plugin-bluebird.ts 100% <ø> (ø) ⬆️
src/config.ts 100% <ø> (ø) ⬆️
src/plugins/plugin-restify.ts 97.14% <ø> (ø) ⬆️
test/web-frameworks/connect.ts 76.92% <ø> (ø) ⬆️
test/web-frameworks/koa2.ts 76.92% <ø> (ø) ⬆️
src/cls/async-listener.ts 100% <ø> (ø) ⬆️
src/trace.ts 100% <ø> (ø) ⬆️
test/web-frameworks/express.ts 75.86% <ø> (ø) ⬆️
src/cls/null.ts 88.88% <ø> (ø) ⬆️
... and 67 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 178c2a9...6096e17. Read the comment docs.

@JustinBeckwith JustinBeckwith requested a review from kjin June 24, 2019 19:31
@JustinBeckwith JustinBeckwith added the status: blocked Resolving the issue is dependent on other work. label Jun 24, 2019
@JustinBeckwith JustinBeckwith removed the status: blocked Resolving the issue is dependent on other work. label Jun 24, 2019
@JustinBeckwith JustinBeckwith added the needs work This is a pull request that needs a little love. label Jun 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement. needs work This is a pull request that needs a little love.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants