-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix RUNPATHs for libraries and executables #3383
Conversation
Several unrelated failures due to the recently added |
Overall OK for inclusion but want to perform few tests before and I prefer to postponed it to v9.5 (~August/September ?) unless you have strong argument(s) (and confidence) to include it in the incoming v9.4.
|
a19c84f
to
13943fd
Compare
82ba36e
to
03b8139
Compare
Now fails to merge due to conflicting changes done in the meantime ... 😞 fa478b8#diff-a54fa3f11d0325be89059b2ab63a3bbeffefa802bf9a66580f14694c3e428d3d |
1e0dd27
to
1ee1e2d
Compare
The old code added several irrelevant, duplicate or even non-existing directories to the RUNPATHs of the samples. Calculate the actual relative path between binary and library install directory (using the absolute paths, CMAKE_INSTALL_LIBDIR may be either relative or absolute), and set it as target property.
The flatzinc library is installed to the same location (LIBDIR) as the ortools library, so "$ORIGIN" suffices. The executables should use the relative path between LIBDIR and BINDIR.
1ee1e2d
to
50e630e
Compare
Dito for linear_solve/solve.
50e630e
to
b275acd
Compare
@Mizux Ping! |
The RUNPATH should be limited to the entries actually required, instead of trying to cover all possible scenarios by adding an entry for each.
Instead of modifying the default RUNPATH by repeatedly setting CMAKE_INSTALL_RPATH, set the correct minimal INSTALL_RPATH property for each executable and library.
Only tested on Linux. Windows should not be affected, MacOS may be wrong.