Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change tint color of icons used in previews #302

Merged
merged 1 commit into from
Jul 1, 2022
Merged

Change tint color of icons used in previews #302

merged 1 commit into from
Jul 1, 2022

Conversation

luizgrp
Copy link
Member

@luizgrp luizgrp commented Jun 30, 2022

WHAT

Change tint color of icons used in previews.

Screen Shot 2022-06-30 at 19 20 01

Screen Shot 2022-06-30 at 19 21 10

WHY

As requested in:

HOW

  • Add helper function rememberVectorPainter which calls the one defined in androidx.compose.ui.graphics.vector but allowing to pass a different tint color as parameter;
  • Change preview code to use this helper function;

Checklist 📋

  • Add explicit visibility modifier and explicit return types for public declarations
  • Run spotless check
  • Run tests
  • Update metalava's signature text files

@luizgrp luizgrp mentioned this pull request Jun 30, 2022
Merged
4 tasks
@luizgrp luizgrp requested a review from yschimke July 1, 2022 07:58
@luizgrp luizgrp merged commit 1e2c616 into google:main Jul 1, 2022
@luizgrp luizgrp deleted the mediaui_tint_preview branch July 1, 2022 08:04
@luizgrp luizgrp self-assigned this Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yschimke yschimke yschimke approved these changes

Assignees

@luizgrp luizgrp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@luizgrp @yschimke