Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MediaChip #291

Merged
merged 1 commit into from
Jun 30, 2022
Merged

Add MediaChip #291

merged 1 commit into from
Jun 30, 2022

Conversation

luizgrp
Copy link
Member

@luizgrp luizgrp commented Jun 29, 2022

WHAT

Add MediaChip.

Screen Shot 2022-06-29 at 12 21 35

WHY

In order to provide common components.

HOW

  • Move MediaChip from media-sample to media-ui;
  • Add defaultTitle and placeholder params;
  • Add previews;
  • Add tests;

Checklist 📋

  • Add explicit visibility modifier and explicit return types for public declarations
  • Run spotless check
  • Run tests
  • Update metalava's signature text files

@yschimke
Copy link
Collaborator

yschimke commented Jun 29, 2022

The previews don't really "pop". Rather than the generic placeholder,

I think Coil supports direct android resources as URL Strings.

https://github.com/coil-kt/coil/blob/main/coil-base/src/androidTest/java/coil/fetch/AssetUriFetcherTest.kt

@luizgrp luizgrp force-pushed the mediaui_mediachip branch from 24270c8 to efb7bbb Compare June 29, 2022 21:02
@luizgrp luizgrp merged commit 3045be0 into google:main Jun 30, 2022
@luizgrp luizgrp deleted the mediaui_mediachip branch June 30, 2022 07:04
@luizgrp luizgrp self-assigned this Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants