Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report Go version without the agent #22

Closed
rakyll opened this issue Dec 5, 2016 · 3 comments
Closed

Report Go version without the agent #22

rakyll opened this issue Dec 5, 2016 · 3 comments

Comments

@rakyll
Copy link
Member

rakyll commented Dec 5, 2016

See Damian's script to dissemble and extract the version information at https://gist.github.com/dgryski/99ac147faf2891c9816d3f4f925c4e6b.

@rsc
Copy link

rsc commented Aug 29, 2017

Fixed?

@odeke-em
Copy link
Collaborator

odeke-em commented Sep 1, 2017

Perhaps what @rsc did in https://github.com/rsc/goversion can be done here too? Or we can transform his work a package and then import it in this package, that's importable and useable here.

@rakyll
Copy link
Member Author

rakyll commented Sep 1, 2017

Thanks @rsc!

@odeke-em, it is already done. I converted goversion into a library at https://github.com/google/gops/tree/master/internal/goversion. We need to remove the version subcommand. Do you want to send a change?

odeke-em added a commit that referenced this issue Sep 2, 2017
Finishes up #22

Remove subcommand `version` after @rsc's goversion
was bundled by @rakyll as an internal package in
1128431,
thus we no longer need to expose `version`.
odeke-em added a commit that referenced this issue Sep 2, 2017
Finishes up #22

Remove subcommand `version` after @rsc's goversion
was bundled by @rakyll as an internal package in
1128431,
thus we no longer need to expose `version`.
odeke-em added a commit that referenced this issue Sep 2, 2017
Finishes up #22

Remove subcommand `version` after @rsc's goversion
was bundled by @rakyll as an internal package in
1128431,
thus we no longer need to expose `version`.
odeke-em added a commit that referenced this issue Sep 4, 2017
Finishes up #22

Remove subcommand `version` after @rsc's goversion
was bundled by @rakyll as an internal package in
1128431,
thus we no longer need to expose `version`.
@rakyll rakyll closed this as completed in d858829 Sep 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants