Skip to content

Commit

Permalink
report go build version
Browse files Browse the repository at this point in the history
  • Loading branch information
@rakyll
rakyll committed Aug 26, 2017
1 parent 806455e commit 1128431
Show file tree
Hide file tree
Showing 2 changed files with 625 additions and 17 deletions.
Loading

4 comments on commit 1128431

@rsc
Copy link

@rsc rsc commented on 1128431 Aug 29, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's probably worth a comment about where this code came from, if for no other reason than that bug fixes should be reported upstream.

@rakyll
Copy link
Member Author

@rakyll rakyll commented on 1128431 Sep 2, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rsc, can you provide a goversion library so I can import directly rather than maintaining a copy here?

@rsc
Copy link

@rsc rsc commented on 1128431 Sep 2, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. import "rsc.io/goversion/version".

@odeke-em
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @rsc!

Please sign in to comment.