fix out of bounds panic

google · Jul 11, 2018 · 89672db · 89672db
1 parent 60aa68d
commit 89672db
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/cmd.go b/cmd.go
@@ -185,7 +185,7 @@ func targetToAddr(target string) (*net.TCPAddr, error) {
 	}
 	port, err := internal.GetPort(pid)
 	if err != nil {
-		return nil, fmt.Errorf("couldn't get port for PID %s: %v", pid, err)
+		return nil, fmt.Errorf("couldn't get port for PID %v: %v", pid, err)
 	}
 	addr, _ := net.ResolveTCPAddr("tcp", "127.0.0.1:"+port)
 	return addr, nil

diff --git a/main.go b/main.go
@@ -72,6 +72,10 @@ func main() {
 	if !ok {
 		usage("unknown subcommand")
 	}
+	if len(os.Args) < 3 {
+		usage("Missing PID or address.")
+		os.Exit(1)
+	}
 	addr, err := targetToAddr(os.Args[2])
 	if err != nil {
 		fmt.Fprintf(os.Stderr, "Couldn't resolve addr or pid %v to TCPAddress: %v\n", os.Args[2], err)