cmd: Check error returned by GetPort (#83)

Before this change, error returned by internal.GetPort was assigned to err variable, but this assignment was ineffectual and error was ignored.
google · Jul 11, 2018 · 60aa68d · 60aa68d
1 parent e4108e7
commit 60aa68d
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 0 deletions.
diff --git a/cmd.go b/cmd.go
@@ -184,6 +184,9 @@ func targetToAddr(target string) (*net.TCPAddr, error) {
 		return nil, fmt.Errorf("couldn't parse PID: %v", err)
 	}
 	port, err := internal.GetPort(pid)
+	if err != nil {
+		return nil, fmt.Errorf("couldn't get port for PID %s: %v", pid, err)
+	}
 	addr, _ := net.ResolveTCPAddr("tcp", "127.0.0.1:"+port)
 	return addr, nil
 }

diff --git a/gops b/gops