Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flag --incompatible_load_java_rules_from_bzl will break Flogger in Bazel 1.2.1 #122

Closed
bazel-flag-bot opened this issue Dec 19, 2019 · 2 comments · Fixed by #134
Closed

Flag --incompatible_load_java_rules_from_bzl will break Flogger in Bazel 1.2.1 #122

bazel-flag-bot opened this issue Dec 19, 2019 · 2 comments · Fixed by #134
Assignees
@cpovirk
Labels
P3 type=defect Bug, not working as expected

Comments

@bazel-flag-bot
Copy link

Incompatible flag --incompatible_load_java_rules_from_bzl will break Flogger once Bazel 1.2.1 is released.

Please see the following CI builds for more information:

Questions? Please file an issue in https://github.com/bazelbuild/continuous-integration

Important: Please do NOT modify the issue title since that might break our tools.
@kluever kluever added P2 type=defect Bug, not working as expected labels Dec 19, 2019
@cpovirk cpovirk mentioned this issue Dec 30, 2019
Closed
@cpovirk
Copy link
Member

cpovirk commented Dec 30, 2019 

(03:02:42) ERROR: /var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/f873cfce23d8c0ab1616447bd64a5841/external/com_google_auto_auto_common/BUILD:7:1: in java_import rule @com_google_auto_auto_common//:com_google_auto_auto_common: The native Java rules are deprecated. Please load java_import from the rules_java repository. See http://github.com/bazelbuild/rules_java and https://github.com/bazelbuild/bazel/issues/8741. You can temporarily bypass this error by setting --incompatible_load_java_rules_from_bzl=false.

etc.

I filed google/bazel-common#97, as I think this needs to be fixed in bazel-common. (And then Flogger will need to update to a new version of bazel-common.)

@cpovirk cpovirk assigned cpovirk and unassigned hagbard Jan 27, 2020
@cpovirk cpovirk added P3 and removed P2 labels Feb 3, 2020
@cpovirk
Copy link
Member

cpovirk commented Feb 3, 2020

P3 because I believe this is blocked by Bazel itself, as noted in google/bazel-common#97

kluever pushed a commit to google/bazel-common that referenced this issue Feb 23, 2020
@cpovirk @kluever
Prepare for --incompatible_load_java_rules_from_bzl.
5062155 
Fixes #97
Progress toward google/flogger#122

I have also tested this against Flogger and Dagger (modified to fix their own --incompatible_load_java_rules_from_bzl problems). Everything appears to work except for Dagger, which has some breakages from bazel_tools itself, for which I have filed bazelbuild/bazel#10839. (This is in addition to filing and working around bazelbuild/bazel#10838.)

It also includes an upgrade to rules_kotlin to contain the analogous fix for that repo: bazelbuild/rules_kotlin@186c1e1

And ditto for protobuf.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=296727595
@kluever kluever mentioned this issue Feb 23, 2020
Merged
kluever pushed a commit to google/bazel-common that referenced this issue Feb 23, 2020
@cpovirk @kluever
Prepare for --incompatible_load_java_rules_from_bzl.
eb5c7e5 
Fixes #97
Progress toward google/flogger#122

I have also tested this against Flogger and Dagger (modified to fix their own --incompatible_load_java_rules_from_bzl problems). Everything appears to work except for Dagger, which has some breakages from bazel_tools itself, for which I have filed bazelbuild/bazel#10839. (This is in addition to filing and working around bazelbuild/bazel#10838.)

It also includes an upgrade to rules_kotlin to contain the analogous fix for that repo: bazelbuild/rules_kotlin@186c1e1

And ditto for protobuf.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=296727595
cpovirk added a commit that referenced this issue Feb 27, 2020
@cpovirk
Prepare for --incompatible_load_java_rules_from_bzl.
561c0cb 
...by load()-ing java_library and other rules wherever we use them.

Fixes #122

Compare to CL 296727595 for bazel_common.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=297412705
@cpovirk cpovirk mentioned this issue Feb 27, 2020
Merged
cpovirk added a commit that referenced this issue Feb 27, 2020
@cpovirk
Prepare for --incompatible_load_java_rules_from_bzl.
2ede603 
...by load()-ing java_library and other rules wherever we use them.

Fixes #122

Compare to CL 296727595 for bazel_common.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=297412705
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cpovirk cpovirk

Labels
P3 type=defect Bug, not working as expected
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

MOE Sync 2020-02-27 google/flogger
4 participants
@hagbard @cpovirk @kluever @bazel-flag-bot