Skip to content

Commit

Permalink
Stop using native java rules (#258)
Browse files Browse the repository at this point in the history
Fixes #247
  • Loading branch information
cgruber authored Jan 15, 2020
1 parent a3d4d56 commit 186c1e1
Show file tree
Hide file tree
Showing 44 changed files with 46 additions and 2 deletions.
1 change: 1 addition & 0 deletions examples/dagger/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
load("@rules_java//java:defs.bzl", "java_binary", "java_library", "java_plugin")
package(default_visibility = ["//visibility:private"])

load("//kotlin:kotlin.bzl", "kt_jvm_library")
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
package(default_visibility = ["//visibility:public"])

load("@io_bazel_rules_kotlin//kotlin:kotlin.bzl", "kt_js_import", "kt_jvm_import")
load("@rules_java//java:defs.bzl", "java_import")

# Kotlin home filegroup containing everything that is needed.
filegroup(
Expand Down
1 change: 1 addition & 0 deletions src/main/kotlin/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
load("@rules_java//java:defs.bzl", "java_binary")
load("//src/main/kotlin:bootstrap.bzl", "kt_bootstrap_library")
load("//kotlin:kotlin.bzl", "kt_jvm_library")
load("//third_party:jarjar.bzl", "jar_jar")
Expand Down
3 changes: 2 additions & 1 deletion src/main/kotlin/bootstrap.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
load("@rules_java//java:defs.bzl", "java_import", "java_library")
load("//kotlin:kotlin.bzl", _for_ide = "kt_jvm_library")

_BOOTSTRAP_LIB_ARGS = ["-jvm-target", "1.8"]
Expand Down Expand Up @@ -100,7 +101,7 @@ rm $(@D)/$${NAME}_temp.jar
],
cmd = command,
)
native.java_import(
java_import(
name = name,
jars = [jar_label],
tags = ["no-ide"],
Expand Down
1 change: 1 addition & 0 deletions src/main/kotlin/io/bazel/kotlin/builder/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
load("@rules_java//java:defs.bzl", "java_library")
load("//src/main/kotlin:bootstrap.bzl", "kt_bootstrap_library")

kt_bootstrap_library(
Expand Down
1 change: 1 addition & 0 deletions src/main/protobuf/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
load("@rules_java//java:defs.bzl", "java_import")
package(default_visibility = ["//visibility:public"])

proto_library(
Expand Down
1 change: 1 addition & 0 deletions src/test/data/jvm/basic/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
# limitations under the License.
package(default_visibility = ["//visibility:private"])

load("@rules_java//java:defs.bzl", "java_binary", "java_library")
load("//kotlin:kotlin.bzl", "kt_jvm_binary", "kt_jvm_library", "kt_jvm_test")

kt_jvm_binary(
Expand Down
1 change: 1 addition & 0 deletions src/test/data/jvm/kapt/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
# limitations under the License.
package(default_visibility = ["//visibility:private"])

load("@rules_java//java:defs.bzl", "java_plugin", "java_library")
load("//kotlin:kotlin.bzl", "kt_jvm_library")

java_plugin(
Expand Down
1 change: 1 addition & 0 deletions src/test/kotlin/io/bazel/kotlin/builder/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
# limitations under the License.
package(default_visibility = ["//visibility:private"])

load("@rules_java//java:defs.bzl", "java_library")
load("//src/test/kotlin/io/bazel/kotlin:defs.bzl", "kt_rules_test")

_COMMON_DEPS = [
Expand Down
3 changes: 2 additions & 1 deletion src/test/kotlin/io/bazel/kotlin/defs.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
load("@rules_java//java:defs.bzl", "java_test")
load("//kotlin:kotlin.bzl", "kt_jvm_test")

def _get_class_name(kwargs):
Expand All @@ -30,7 +31,7 @@ def kt_rules_test(name, **kwargs):
if f.endswith(".kt"):
kt_jvm_test(name = name, **kwargs)
return
native.java_test(name = name, **kwargs)
java_test(name = name, **kwargs)

def kt_rules_e2e_test(name, **kwargs):
kwargs.setdefault("size", "small")
Expand Down
1 change: 1 addition & 0 deletions third_party/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
# limitations under the License.
package(default_visibility = ["//visibility:public"])

load("@rules_java//java:defs.bzl", "java_binary", "java_library", "java_plugin")
load("//kotlin:kotlin.bzl", "kt_jvm_import")


Expand Down
1 change: 1 addition & 0 deletions third_party/jvm/com/google/auto/BUILD
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
load("@rules_java//java:defs.bzl", "java_library")
licenses(["notice"])

java_library(
Expand Down
1 change: 1 addition & 0 deletions third_party/jvm/com/google/auto/service/BUILD
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
load("@rules_java//java:defs.bzl", "java_library")
licenses(["notice"])

java_library(
Expand Down
1 change: 1 addition & 0 deletions third_party/jvm/com/google/auto/value/BUILD
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
load("@rules_java//java:defs.bzl", "java_library")
licenses(["notice"])

java_library(
Expand Down
1 change: 1 addition & 0 deletions third_party/jvm/com/google/code/findbugs/BUILD
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
load("@rules_java//java:defs.bzl", "java_library")
licenses(["notice"])

java_library(
Expand Down
1 change: 1 addition & 0 deletions third_party/jvm/com/google/code/gson/BUILD
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
load("@rules_java//java:defs.bzl", "java_library")
licenses(["notice"])

java_library(
Expand Down
1 change: 1 addition & 0 deletions third_party/jvm/com/google/dagger/BUILD
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
load("@rules_java//java:defs.bzl", "java_library")
licenses(["notice"])

java_library(
Expand Down
1 change: 1 addition & 0 deletions third_party/jvm/com/google/errorprone/BUILD
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
load("@rules_java//java:defs.bzl", "java_library")
licenses(["notice"])

java_library(
Expand Down
1 change: 1 addition & 0 deletions third_party/jvm/com/google/googlejavaformat/BUILD
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
load("@rules_java//java:defs.bzl", "java_library")
licenses(["notice"])

java_library(
Expand Down
1 change: 1 addition & 0 deletions third_party/jvm/com/google/guava/BUILD
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
load("@rules_java//java:defs.bzl", "java_library")
licenses(["notice"])

java_library(
Expand Down
1 change: 1 addition & 0 deletions third_party/jvm/com/google/j2objc/BUILD
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
load("@rules_java//java:defs.bzl", "java_library")
licenses(["notice"])

java_library(
Expand Down
1 change: 1 addition & 0 deletions third_party/jvm/com/google/protobuf/BUILD
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
load("@rules_java//java:defs.bzl", "java_library")
licenses(["notice"])

java_library(
Expand Down
1 change: 1 addition & 0 deletions third_party/jvm/com/google/truth/BUILD
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
load("@rules_java//java:defs.bzl", "java_library")
licenses(["notice"])

java_library(
Expand Down
1 change: 1 addition & 0 deletions third_party/jvm/com/googlecode/java_diff_utils/BUILD
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
load("@rules_java//java:defs.bzl", "java_library")
licenses(["notice"])

java_library(
Expand Down
1 change: 1 addition & 0 deletions third_party/jvm/com/squareup/BUILD
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
load("@rules_java//java:defs.bzl", "java_library")
licenses(["notice"])

java_library(
Expand Down
1 change: 1 addition & 0 deletions third_party/jvm/javax/annotation/BUILD
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
load("@rules_java//java:defs.bzl", "java_library")
licenses(["notice"])

java_library(
Expand Down
1 change: 1 addition & 0 deletions third_party/jvm/javax/enterprise/BUILD
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
load("@rules_java//java:defs.bzl", "java_library")
licenses(["notice"])

java_library(
Expand Down
1 change: 1 addition & 0 deletions third_party/jvm/javax/inject/BUILD
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
load("@rules_java//java:defs.bzl", "java_library")
licenses(["notice"])

java_library(
Expand Down
1 change: 1 addition & 0 deletions third_party/jvm/junit/BUILD
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
load("@rules_java//java:defs.bzl", "java_library")
licenses(["notice"])

java_library(
Expand Down
1 change: 1 addition & 0 deletions third_party/jvm/net/ltgt/gradle/incap/BUILD
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
load("@rules_java//java:defs.bzl", "java_library")
licenses(["notice"])

java_library(
Expand Down
1 change: 1 addition & 0 deletions third_party/jvm/org/apache/ant/BUILD
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
load("@rules_java//java:defs.bzl", "java_library")
licenses(["notice"])

java_library(
Expand Down
1 change: 1 addition & 0 deletions third_party/jvm/org/apache/commons/BUILD
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
load("@rules_java//java:defs.bzl", "java_library")
licenses(["notice"])

java_library(
Expand Down
1 change: 1 addition & 0 deletions third_party/jvm/org/apache/maven/BUILD
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
load("@rules_java//java:defs.bzl", "java_library")
licenses(["notice"])

java_library(
Expand Down
1 change: 1 addition & 0 deletions third_party/jvm/org/checkerframework/BUILD
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
load("@rules_java//java:defs.bzl", "java_library")
licenses(["notice"])

java_library(
Expand Down
1 change: 1 addition & 0 deletions third_party/jvm/org/codehaus/mojo/BUILD
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
load("@rules_java//java:defs.bzl", "java_library")
licenses(["notice"])

java_library(
Expand Down
1 change: 1 addition & 0 deletions third_party/jvm/org/codehaus/plexus/BUILD
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
load("@rules_java//java:defs.bzl", "java_library")
licenses(["notice"])

java_library(
Expand Down
1 change: 1 addition & 0 deletions third_party/jvm/org/eclipse/sisu/BUILD
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
load("@rules_java//java:defs.bzl", "java_library")
licenses(["notice"])

java_library(
Expand Down
1 change: 1 addition & 0 deletions third_party/jvm/org/hamcrest/BUILD
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
load("@rules_java//java:defs.bzl", "java_library")
licenses(["notice"])

java_library(
Expand Down
1 change: 1 addition & 0 deletions third_party/jvm/org/jetbrains/BUILD
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
load("@rules_java//java:defs.bzl", "java_library")
licenses(["notice"])

java_library(
Expand Down
1 change: 1 addition & 0 deletions third_party/jvm/org/jetbrains/kotlin/BUILD
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
load("@rules_java//java:defs.bzl", "java_library")
licenses(["notice"])

java_library(
Expand Down
1 change: 1 addition & 0 deletions third_party/jvm/org/jetbrains/kotlinx/BUILD
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
load("@rules_java//java:defs.bzl", "java_library")
licenses(["notice"])

java_library(
Expand Down
1 change: 1 addition & 0 deletions third_party/jvm/org/ow2/asm/BUILD
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
load("@rules_java//java:defs.bzl", "java_library")
licenses(["notice"])

java_library(
Expand Down
1 change: 1 addition & 0 deletions third_party/jvm/org/pantsbuild/BUILD
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
load("@rules_java//java:defs.bzl", "java_library")
licenses(["notice"])

java_library(
Expand Down
1 change: 1 addition & 0 deletions third_party/jvm/workspace.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ def _jar_artifact_impl(ctx):
srcjar_attr = '\n srcjar = ":%s",' % src_name

build_file_contents = """
load("@rules_java//java:defs.bzl", "java_import")
package(default_visibility = ['//visibility:public'])
java_import(
name = 'jar',
Expand Down

0 comments on commit 186c1e1

Please sign in to comment.