-
Notifications
You must be signed in to change notification settings - Fork 918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Google Analytics section of UG #1098
Conversation
[services] | ||
[services.googleAnalytics] | ||
# Comment out the next line to disable GA tracking. Also disables the feature described in [params.ui.feedback]. | ||
id = "UA-00000000-0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update: I moved the ID to earlier in the file. It can still be used while we wait for a "real" ID (#1097).
FYI, I posted this question: https://discourse.gohugo.io/t/config-is-services-googleanalytics-id-an-alias-for-googleanalytics/39469. If it turns out that they are (officially) aliases, I'll add a note to that effect to the GA section. |
5f333ac
to
4367665
Compare
All: this is ready for review. I decided to simplify this change by referring the reader to the appropriate section of the Hugo docs. The page update includes a warning (about not setting both |
3162be6
to
de7ac01
Compare
562183d
to
684394a
Compare
Should we open an issue to track this? |
684394a
to
f7ebc1f
Compare
f7ebc1f
to
b31a73a
Compare
Done: Given @geriom's approval, I'm going to merge. |
Preview: https://deploy-preview-1098--docsydocs.netlify.app/docs/adding-content/feedback/#adding-analytics