Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User guide: reenable page Feedback #1099

Closed
chalin opened this issue Jul 12, 2022 · 1 comment
Closed

User guide: reenable page Feedback #1099

chalin opened this issue Jul 12, 2022 · 1 comment
Labels
analytics e0-minutes Effort < 60 min p3-low user guide Improvements to user guide

Comments

@chalin
Copy link
Collaborator

chalin commented Jul 12, 2022

PR #1098 removed (what I believe to be) the bogus analytics ID that was being used. As a consequence, the page feedback widget will no longer appear. Once #1097 is resolved, this issue should automatically be resolved too, but I'm creating a separate issue in case folks notice that the feedback form is gone and scan the issue list for "feedback" :).
@chalin chalin added user guide Improvements to user guide e0-minutes Effort < 60 min p3-low labels Jul 12, 2022
@chalin chalin mentioned this issue Jul 12, 2022
Merged
@chalin
Copy link
Collaborator Author

chalin commented Jul 12, 2022

After some thought I decided to re-introduce the bogus GA ID via the now recommended top-level config param. So, closing this issue.

@chalin chalin closed this as completed Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
analytics e0-minutes Effort < 60 min p3-low user guide Improvements to user guide
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@chalin