Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't set the HOST_JOB_SELECTION env var to a 404 error page #4690

Merged
merged 2 commits into from
Feb 12, 2025

Conversation

jonathanmetzman
Copy link
Collaborator

#4663 was not widely deployed but it stops fuzzing wherever HOST_JOB_SELECTION isn't set. That's because it gets set to a 404 HTML page if unset. This in turn interferes with job selection.

#4663 was not widely deployed
but it stops fuzzing wherever HOST_JOB_SELECTION isn't set.
That's because it gets set to a 404 HTML page if unset.
This in turn interferes with job selection.
Copy link
Collaborator

@vitaliset vitaliset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonathanmetzman jonathanmetzman merged commit 549bdb6 into master Feb 12, 2025
6 checks passed
@jonathanmetzman jonathanmetzman deleted the select branch February 12, 2025 00:31
@jonathanmetzman
Copy link
Collaborator Author

CC @letitz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants