Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to set HOST_JOB_SELECTION from instance metadata. #4663

Merged
merged 2 commits into from
Feb 5, 2025

Conversation

letitz
Copy link
Collaborator

@letitz letitz commented Feb 5, 2025

This allows spinning up instances dedicated to a subset of jobs without creating dedicated docker images.

Chrome would like to experiment with spending more compute on a relatively small number of fuzzers.

Bug: https://crbug.com/394563978

Copy link
Collaborator

@jonathanmetzman jonathanmetzman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@letitz letitz changed the title Add ability to set COMMAND_OVERRIDE from instance metadata. Add ability to set HOST_JOB_SELECTION from instance metadata. Feb 5, 2025
@letitz letitz marked this pull request as ready for review February 5, 2025 15:18
Copy link
Collaborator

@jonathanmetzman jonathanmetzman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@letitz letitz merged commit 2ebd2d5 into google:master Feb 5, 2025
7 checks passed
@letitz letitz deleted the cmdoverride branch February 5, 2025 16:20
jonathanmetzman added a commit that referenced this pull request Feb 11, 2025
#4663 was not widely deployed
but it stops fuzzing wherever HOST_JOB_SELECTION isn't set.
That's because it gets set to a 404 HTML page if unset.
This in turn interferes with job selection.
jonathanmetzman added a commit that referenced this pull request Feb 12, 2025
#4663 was not widely deployed
but it stops fuzzing wherever HOST_JOB_SELECTION isn't set. That's
because it gets set to a 404 HTML page if unset. This in turn interferes
with job selection.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants