deprecate: edit row separator readme to deprecate it #1920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BeksOmega
suggested changes
Sep 13, 2023
There was a problem hiding this comment.
@johnnesky Can you:
- Rebase this on the 2023-q3-eq-release branch so we can merge it but save it until EOQ?
- Mark the package as private so we don't publish further versions of it accidentally?
otherwise this LGTM!
59792b5 to
98caaff
Compare
|
Done! |
BeksOmega
approved these changes
Sep 18, 2023
BeksOmega
pushed a commit
to BeksOmega/blockly-samples
that referenced
this pull request
Sep 19, 2023
* chore: edit row separator readme to deprecate it. * Mark deprecated package private to stop publishing
BeksOmega
pushed a commit
to BeksOmega/blockly-samples
that referenced
this pull request
Sep 19, 2023
* chore: edit row separator readme to deprecate it. * Mark deprecated package private to stop publishing
BeksOmega
pushed a commit
to BeksOmega/blockly-samples
that referenced
this pull request
Sep 28, 2023
* chore: edit row separator readme to deprecate it. * Mark deprecated package private to stop publishing
BeksOmega
pushed a commit
to BeksOmega/blockly-samples
that referenced
this pull request
Sep 28, 2023
* chore: edit row separator readme to deprecate it. * Mark deprecated package private to stop publishing
BeksOmega
pushed a commit
that referenced
this pull request
Sep 28, 2023
* chore: edit row separator readme to deprecate it. * Mark deprecated package private to stop publishing
BeksOmega
added a commit
that referenced
this pull request
Sep 28, 2023
* fix: upgrade keyboard navigation to use new clipboard API (#1844) * fix: upgrade keyboard navigation to use new clipboard API * chore: reorganize test suites * chore: fixup delete tests * chore: work on fixing copy tests * chore: finish fixing up copy tests * chore: fix cut and paste tests * chore: delete paste suite * chore: delete unnecessary test helpers * chore: fixup other tests * chore: document why we're stubbing cancelAnimationFrame and add it to teardown * fix: upgrade cross tab copy paste to use new clipboard API (#1845) * fix: upgrade cross tab copy paste to use new clipboard API * chore: update to beta * fix: upgrade shareable procedures for new clipboard API (#1863) * chore: fix tests * fix: upgrade the shareable procedure blocks to use the new clipboard system * chore: update blockly version * chore: fix lint * fix: serialization of dynamic if blocks (#1880) * fix: normalize inputs * fix: work on fixing serialization * chore: remove inputCounts * chore: fix tests * fix: infinite loop * fix: serialization of dynamic list blocks (#1885) * fix: normalize inputs * fix: serialization * chore: remove inputCounter * fix: normalize connections from load * chore: switch tests to regexp * chore: refactor tests * fix: rebuilding behavior * chore: revert changes to playground * chore: format * fix: fully tear down dynamic block before rebuilding (#1886) * fix: dynamic text serialization (#1887) * fix: normalize inputs * fix: serialization * chore: remove inputCounter * fix: normalize connections from load * chore: switch tests to regexp * chore: refactor tests * feat: dynamic json serialization (#1888) * feat: add json serialization for text and list dynamic blocks * chore: use helpers to append inputs * chore: add json serialization to if blocks * fix: support loading stringified XML from JSOn * fix: dynamic connection plugin readme (#1919) * chore: update readme and remove warning * chore: add backticks * deprecate: edit row separator readme to deprecate it (#1920) * chore: edit row separator readme to deprecate it. * Mark deprecated package private to stop publishing * fix: unnamed callers for shareable procedures (#1983) * fix: rendering dynamic connections (#1984) * fix: migrating json for dynamic connections (#1985) * chore: get tests to fail * fix: round tripping old json to new json * chore: fixup fixes * chore: give up on getting tests to fail properly * fix: fixup keyboard nav to remove blockly version check (#1991) * fix: fixup keyboard nav to remove check * chore: update beta version * fix: bump blockly to v10.2.0 --------- Co-authored-by: John Nesky <nesky@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves
Addresses part of: #1854
Proposed Changes
Updates the renderer-inline-row-separators plugin's readme to indicate that the plugin is deprecated, explains how to use the new alternative feature.
Reason for Changes
The plugin is made obsolete by a feature in an upcoming version of Blockly: google/blockly#6944
Additional Information
The new core Blockly feature is not actually available yet. These readme changes link to a release that has not been published yet, and to documentation that is not up to date yet. See associated documentation changes: cl/559132536 and google/blockly#7360