-
Notifications
You must be signed in to change notification settings - Fork 630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: dynamic if teardown #1886
Merged
BeksOmega
merged 1 commit into
google:block-dynamic-serialization
from
BeksOmega:fix/dynamic-if-teardown
Sep 7, 2023
Merged
fix: dynamic if teardown #1886
BeksOmega
merged 1 commit into
google:block-dynamic-serialization
from
BeksOmega:fix/dynamic-if-teardown
Sep 7, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BeksOmega
force-pushed
the
block-dynamic-serialization
branch
from
September 7, 2023 15:44
5eb3192
to
545ae90
Compare
BeksOmega
force-pushed
the
fix/dynamic-if-teardown
branch
from
September 7, 2023 17:17
bf8c324
to
4572e8a
Compare
NeilFraser
approved these changes
Sep 7, 2023
BeksOmega
added a commit
that referenced
this pull request
Sep 14, 2023
BeksOmega
added a commit
to BeksOmega/blockly-samples
that referenced
this pull request
Sep 19, 2023
BeksOmega
added a commit
to BeksOmega/blockly-samples
that referenced
this pull request
Sep 19, 2023
BeksOmega
added a commit
to BeksOmega/blockly-samples
that referenced
this pull request
Sep 28, 2023
BeksOmega
added a commit
to BeksOmega/blockly-samples
that referenced
this pull request
Sep 28, 2023
BeksOmega
added a commit
that referenced
this pull request
Sep 28, 2023
BeksOmega
added a commit
that referenced
this pull request
Sep 28, 2023
* fix: upgrade keyboard navigation to use new clipboard API (#1844) * fix: upgrade keyboard navigation to use new clipboard API * chore: reorganize test suites * chore: fixup delete tests * chore: work on fixing copy tests * chore: finish fixing up copy tests * chore: fix cut and paste tests * chore: delete paste suite * chore: delete unnecessary test helpers * chore: fixup other tests * chore: document why we're stubbing cancelAnimationFrame and add it to teardown * fix: upgrade cross tab copy paste to use new clipboard API (#1845) * fix: upgrade cross tab copy paste to use new clipboard API * chore: update to beta * fix: upgrade shareable procedures for new clipboard API (#1863) * chore: fix tests * fix: upgrade the shareable procedure blocks to use the new clipboard system * chore: update blockly version * chore: fix lint * fix: serialization of dynamic if blocks (#1880) * fix: normalize inputs * fix: work on fixing serialization * chore: remove inputCounts * chore: fix tests * fix: infinite loop * fix: serialization of dynamic list blocks (#1885) * fix: normalize inputs * fix: serialization * chore: remove inputCounter * fix: normalize connections from load * chore: switch tests to regexp * chore: refactor tests * fix: rebuilding behavior * chore: revert changes to playground * chore: format * fix: fully tear down dynamic block before rebuilding (#1886) * fix: dynamic text serialization (#1887) * fix: normalize inputs * fix: serialization * chore: remove inputCounter * fix: normalize connections from load * chore: switch tests to regexp * chore: refactor tests * feat: dynamic json serialization (#1888) * feat: add json serialization for text and list dynamic blocks * chore: use helpers to append inputs * chore: add json serialization to if blocks * fix: support loading stringified XML from JSOn * fix: dynamic connection plugin readme (#1919) * chore: update readme and remove warning * chore: add backticks * deprecate: edit row separator readme to deprecate it (#1920) * chore: edit row separator readme to deprecate it. * Mark deprecated package private to stop publishing * fix: unnamed callers for shareable procedures (#1983) * fix: rendering dynamic connections (#1984) * fix: migrating json for dynamic connections (#1985) * chore: get tests to fail * fix: round tripping old json to new json * chore: fixup fixes * chore: give up on getting tests to fail properly * fix: fixup keyboard nav to remove blockly version check (#1991) * fix: fixup keyboard nav to remove check * chore: update beta version * fix: bump blockly to v10.2.0 --------- Co-authored-by: John Nesky <nesky@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependent on #1885
Work on #1843
Tears down the entire block instead of leaving the top input. This was causing a bug as outlined below.
Also deprecated
minInputs
since it's not being used, and implementing it like I did for the list blocks seems like more hastle than it's worth.The Bug
Sometimes your if an else-ifs would be out of order, or you would get two else-ifs instead of one if and one else-if. This only happened when loading from the old serialization format.
To Reproduce
Testing
Retested the reproduction steps and this no longer reproduces.