Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🩹 Fix: genericParseType parsing large uint leads to overflow #3315

Merged
merged 2 commits into from
Feb 20, 2025
Merged

🩹 Fix: genericParseType parsing large uint leads to overflow #3315

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a6c24bb
🩹 Fix: genericParseType parsing large uint leads to overflow
ksw2000 Feb 19, 2025
8e66376
♻️ Refactor: use strconv.FormatUint instead of fmt.Sprintf
ksw2000 Feb 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions ctx_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5522,6 +5522,10 @@
value: uint(4),
str: "4",
},
{
value: ^uint(0),
str: fmt.Sprintf("%d", ^uint(0)),

Check failure on line 5527 in ctx_test.go

View workflow job for this annotation

GitHub Actions / lint 

fmt.Sprintf can be replaced with faster strconv.FormatUint (perfsprint)
},
}

for _, test := range uints {
Expand Down
2 changes: 1 addition & 1 deletion helpers.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -796,7 +796,7 @@ func genericParseType[V GenericType](str string, v V, defaultValue ...V) V {
case int64:
return genericParseInt[V](str, 64, func(i int64) V { return assertValueType[V, int64](i) }, defaultValue...)
case uint:
return genericParseUint[V](str, 32, func(i uint64) V { return assertValueType[V, uint](uint(i)) }, defaultValue...)
return genericParseUint[V](str, 0, func(i uint64) V { return assertValueType[V, uint](uint(i)) }, defaultValue...)
case uint8:
return genericParseUint[V](str, 8, func(i uint64) V { return assertValueType[V, uint8](uint8(i)) }, defaultValue...)
case uint16:
Expand Down
Loading