Fix node duplication in scene sub-inheritance

[RandomShaper]

This was initially done for 2.1, but I think that master also needs it.

UPDATE: Still happens sometimes. :( Not ready for merging.

UPDATE: This may also fix some issues with properties of inherited nodes (and even connections and groups). Or even broken something there. If have no time to look for the improvements in that regard, so if someone finds this is fixing some issue of that kind, please report them as such.

UPDATE: With the last push most problems are solved. I'll open another issue report for the remaining cases.

[volzhs]

maybe should return -1 at the end of method.

[RandomShaper]

Good point. I overlooked that while porting to master. Will be present on the next push. El 08/03/2017 a las 16:17, volzhs escribió:

…

***@***.**** commented on this pull request. ------------------------------------------------------------------------ In scene/resources/packed_scene.cpp <#7979 (comment)>: > } return nid; } + +int SceneState::_find_base_scene_node_remap_key(int p_idx) const { + + for (Map<int, int>::Element *E = base_scene_node_remap.front(); E; E = E->next()) { + if (E->value() == p_idx) { + return E->key(); + } + } +} maybe should return -1 at the end of method. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#7979 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ALQCtmRodf2vy0RgSpODySIYW-JieB6Mks5rjsaHgaJpZM4MWOcm>.