Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.x] GLTF: Move shared defines into a file and only list used extensions #69320

Merged
merged 2 commits into from
Nov 30, 2022
Merged

[3.x] GLTF: Move shared defines into a file and only list used extensions #69320

merged 2 commits into from
Nov 30, 2022

Conversation

aaronfranke
Copy link
Member

This PR backports #63373 and #63399 to Godot 3.x. Does not break compat.

I am planning to backport the entire GLTF module similarly to what #49120 did, but it's a lot safer and easier to review if I do it in small chunks. So here's the first small chunk which backports two PRs. And yes, I tested it.

@aaronfranke aaronfranke added this to the 3.x milestone Nov 29, 2022
@aaronfranke aaronfranke requested a review from a team as a code owner November 29, 2022 00:29
@aaronfranke aaronfranke force-pushed the 3.x-gltf-def-ext-usage branch from bb25f2e to 67c2ac9 Compare November 29, 2022 00:30
fire
fire approved these changes Nov 29, 2022
View reviewed changes
Copy link
Member

@fire fire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't looked at Godot Engine 3 in a bit. So letting you know to share some responsibility to validate and make sure it's ok to merge into stable!

There's a few outstanding bugs in gltf that were fixed in 4 and not 3.

@aaronfranke aaronfranke force-pushed the 3.x-gltf-def-ext-usage branch from 67c2ac9 to f1febed Compare November 29, 2022 06:09
@akien-mga akien-mga modified the milestones: 3.x, 3.6 Nov 30, 2022
@akien-mga akien-mga merged commit d7cb3d9 into godotengine:3.x Nov 30, 2022
@akien-mga
Copy link
Member

Thanks!

@aaronfranke aaronfranke deleted the 3.x-gltf-def-ext-usage branch December 1, 2022 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fire fire fire approved these changes

Assignees
No one assigned
Labels
enhancement topic:import topic:3d
Projects
None yet
Milestone
3.6
Development

Successfully merging this pull request may close these issues.
3 participants
@aaronfranke @akien-mga @fire