GLTF: Move shared defines into a separate gltf_defines.h
file
#63399
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a nutshell, the current way the GLTF module works is like this:
As such, I found the current header situation confusing, since most of the small classes are including GLTFDocument. This PR fixes this confusing situation by moving the shared defines to a separate
gltf_defines.h
file, and moving the template conversion methods into a separategltf_template_convert.h
file. Now, there's a lot less including ofgltf_document.h
, and GLTFDocument declaringfriend class
is not necessary anymore.