Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added z-corrected option for parallax #62002

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

KaruroChori
Copy link

A copy of #61990 on a new fork to better follow the guidelines about rebasing.
Hopefully this time I learned how to do it properly.

Fixing #61903

@clayjohn
Copy link
Member

It looks fine to me. Dividing by the tangent space view.z is technically the more correct but most implementations of plain parallax mapping omit it as a "depth bias" (http://pds5.egloos.com/pds/200709/04/03/parallax_mapping.pdf). https://web.engr.oregonstate.edu/~mjb/cs519/Projects/Papers/Parallax_Occlusion_Mapping.pdf suggests that the depth bias can be removed for deep parallax mapping.

Overall, I'm not convinced that this warrants an extra setting. I have a feeling we can just improve the artifacts and then always have "corrected_z" enabled

@Calinou
Copy link
Member

Calinou commented Jun 28, 2022

Overall, I'm not convinced that this warrants an extra setting. I have a feeling we can just improve the artifacts and then always have "corrected_z" enabled

I would also prefer if this is enabled by default, so that users can benefit from it immediately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants