Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the appearance of Deep Parallax in SpatialMaterial #51712

Closed

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Aug 16, 2021

3.x version of #50377. See also #51433.

This better preserves depth when viewed at oblique angles. Artifacts due to the amount of layers being low may be more noticeable as a result, but it's generally better to decrease the heightmap scale instead.

This is done by dividing the delta by the dot product of the view vector and normal vector.

This better preserves depth when viewed at oblique angles.
Artifacts due to the amount of layers being low may be more noticeable
as a result, but it's generally better to decrease the heightmap scale
instead.

This is done by dividing the delta by the dot product of the view
vector and normal vector.
@Calinou Calinou force-pushed the spatialmaterial-improve-deep-parallax branch from 12f0f2c to 0a635d4 Compare August 16, 2021 03:42
@akien-mga akien-mga modified the milestones: 3.4, 3.5 Nov 8, 2021
@akien-mga akien-mga force-pushed the 3.x branch 2 times, most recently from 71cb8d3 to c58391c Compare January 6, 2022 22:40
@akien-mga akien-mga modified the milestones: 3.5, 3.x Jul 3, 2022
@Calinou
Copy link
Member Author

Calinou commented Jun 27, 2023

Closing, as #50377 was rejected. If #62002 is merged, we could consider backporting it to 3.x.

@akien-mga akien-mga closed this Jun 27, 2023
@YuriSizov YuriSizov removed this from the 3.x milestone Dec 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants