Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove RES and REF typedefs in favor of spelled out Ref<> #60714

Merged
merged 1 commit into from
May 3, 2022
Merged

Remove RES and REF typedefs in favor of spelled out Ref<> #60714

merged 1 commit into from
May 3, 2022

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented May 2, 2022

These typedefs don't save much typing compared to the full Ref<Resource> and Ref<RefCounted>, yet they sometimes introduce confusion among new contributors.

See #33027 (comment).

@Calinou
Remove RES and REF typedefs in favor of spelled out Ref<>
180e5d3 
These typedefs don't save much typing compared to the full `Ref<Resource>`
and `Ref<RefCounted>`, yet they sometimes introduce confusion among
new contributors.
@Calinou Calinou requested review from a team as code owners May 2, 2022 23:44
@Calinou Calinou removed request for a team May 2, 2022 23:45
@Calinou Calinou removed request for a team May 2, 2022 23:45
@Calinou Calinou added this to the 4.0 milestone May 2, 2022
@fire
Copy link
Member

fire commented May 3, 2022

I don't understand why there is a REF either. So this makes sense to remove confusing features.

akien-mga
akien-mga approved these changes May 3, 2022
View reviewed changes
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved in PR review meeting.

@akien-mga akien-mga merged commit 297241f into godotengine:master May 3, 2022
@akien-mga
Copy link
Member

Thanks!

@Calinou Calinou deleted the typedef-remove-ref branch May 3, 2022 16:19
@lufog lufog mentioned this pull request May 25, 2022
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhilbrunner mhilbrunner mhilbrunner approved these changes

@akien-mga akien-mga akien-mga approved these changes

@bruvzg bruvzg bruvzg approved these changes

@Geometror Geometror Geometror approved these changes

Assignees
No one assigned
Labels
enhancement topic:codestyle
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
6 participants
@Calinou @fire @akien-mga @mhilbrunner @bruvzg @Geometror