-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync with Godot master #53
Conversation
Hooray! The module is compiles and works with Godot master branch. From unresolved:
|
the Image::Format enum was changed, so we have to use a compatibility function to convert to the correct enum value
Because we don't explicitly close or delete files any more, file handles will remain open if referenced and have to be explicitly unreferenced to close them if that reference does not go out of scope We also have to explicitly flush or unreference the object in order to get it to write the bytes to disk
Thank you very much for this! I was really dreading updating the master sync for release, so I'm glad someone did it for me :) I added a few commits:
It's surprising to me just how much the API is changing at this late in the development cycle; I probably won't update the sync again until v4 gets closer to release, I think. |
CI is currently broken, but I've validated this locally. I'll PR a fix for the CI shortly. |
For fun, I'm trying to compile this module on the master branch.
Task list:
RES
andREF
typedefs in favor of spelled outRef<>
godotengine/godot#60714elements
tocolumns
androws
respectively godotengine/godot#60627Btw, I'm not sure that I can do everything on my own. And Idk what I'm doing. Therefore, all interested don't hesitate to join.