Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Decal distance fade smoother #58298

Merged

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Feb 18, 2022

Follow-up to #57535 and #58296 (can be merged independently).

smoothstep() avoids the sudden transparency jump when entering or leaving a decal's distance fade margin distance. This in turn helps make opacity transitions less noticeable to the player, as it's less likely to catch the player's eye.

Testing project: test_decal_distance_fade.zip

Preview

Left: Before, Right: After

decal-distance-fade-comparison.mp4

@Calinou Calinou requested a review from a team as a code owner February 18, 2022 21:53
@Calinou Calinou added this to the 4.0 milestone Feb 18, 2022
@Calinou Calinou force-pushed the decal-distance-fade-use-easing branch from c683d01 to 251c516 Compare February 19, 2022 00:12
`smoothstep()` avoids the sudden transparency jump when entering or
leaving a decal's distance fade margin distance. This in turn helps
make opacity transitions less noticeable to the player, as it's
less likely to catch the player's eye.
@Calinou Calinou force-pushed the decal-distance-fade-use-easing branch from 521b352 to 618c88c Compare May 2, 2022 21:14
@akien-mga akien-mga merged commit c114823 into godotengine:master May 4, 2022
@akien-mga
Copy link
Member

Thanks!

@Calinou Calinou deleted the decal-distance-fade-use-easing branch May 4, 2022 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants