Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak Decal distance fade defaults and add property hints #58296

Merged

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Feb 18, 2022

The new default values are more usable in real world scenarios when smooth fading of distant decals is desired for performance reasons.

The Decal distance fade property hints were adjusted based on the GeometryInstance3D visibility range fade property hints. or_greater was also added to allow specifying larger values if needed.

Distance fade remains disabled by default, so the default behavior is unchanged.

Copy link
Member

@clayjohn clayjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once conflicts are resolved!

The new default values are more usable in real world scenarios
when smooth fading of distant decals is desired for performance reasons.

The Decal distance fade property hints were adjusted based on the
GeometryInstance3D visibility range fade property hints. `or_greater`
was also added to allow specifying larger values if needed.
@Calinou Calinou force-pushed the decal-distance-fade-tweak-defaults branch from 1b58818 to a151a74 Compare July 27, 2022 01:16
@akien-mga akien-mga merged commit cade90a into godotengine:master Jul 27, 2022
@akien-mga
Copy link
Member

Thanks!

@Calinou Calinou deleted the decal-distance-fade-tweak-defaults branch July 27, 2022 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants