Fix translations update in window & Dialogs (AcceptDialog/ConfirmationDialog/FileDialog) (Fix 39320, 39258 & 45887)

[fabriceci]

• • Fix Built In button in dialog cannot change translation #39320 by handling NOTIFICATION_TRANSLATION_CHANGED in the Window object

fix.mp4

• Fix Dialog titles get serialized to scene file when using editor in non-English language #39258 where title variable on Window was used as translation instead of the translation key.

fix2.mp4

[Edit]
Updated to also fix #45887

For reviewers:

For refreshing the window:

// I used
child_controls_changed();
// but this works too
if (embedder) {
	embedder->_sub_window_update(this);
}

However, I don't understand well the difference between _sub_windows_update and child_controls_changed as the last one end by calling _sub_windows_update. Both works, but I'm not sure which is the best.

[KoBeWi]

However, I don't understand well the difference between _sub_windows_update and child_controls_changed as the last one end by calling _sub_windows_update. Both works, but I'm not sure which is the best.

I suppose it doesn't matter. The latter does more under the hood, so it might be more correct at the cost of performance, but you don't change translation very often anyways.

I tested the changes both in the editor and exported project and all seem to work fine.

[akien-mga]

This likely breaks editor translations. Try to run make update and make merge in editor/translations/ after this PR and it will likely remove all translations for those strings. RTR() is what is used to extract strings to translate in the template.

[KoBeWi]

Maybe we could add a new macro that fetches strings, but doesn't translate?

[KoBeWi]

Seems like this is what TTRC does, but judging from the comment, it's not the intended use.

[KoBeWi]

Actually TTRC is fine. So replace the removed RTRs with TTRCs.

[fabriceci]

@akien-mga thanks, I was unaware of this behaviour.

@KoBeWi thanks for the review and providing me a solution! Changes are done.

By curiosity, how I can see what functions are used for generating translations? (For example, is the tr() function is used too?).

[KoBeWi]

By curiosity, how I can see what functions are used for generating translations? (For example, is the tr() function is used too?).

They are defined here:

godot/editor/translations/extract.py

Line 186 in bf309b8

patterns = ['RTR("', 'TTR("', 'TTRC("', 'TTRN("', 'RTRN("']

[akien-mga]

Thanks!

[akien-mga]

This could be useful to backport to the 3.x branch, but it would need a dedicated PR and testing as Window is new in master, for 3.x it would likely need changes in the Dialog implementation itself.