Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FileDialog doesn't translate some strings properly #56947

Closed
KoBeWi opened this issue Jan 19, 2022 · 0 comments · Fixed by #56963
Closed

FileDialog doesn't translate some strings properly #56947

KoBeWi opened this issue Jan 19, 2022 · 0 comments · Fixed by #56963

Comments

@KoBeWi
Copy link
Member

KoBeWi commented Jan 19, 2022

Godot version

7a88f5c

System information

W10

Issue description

After #46735, the "All Recognized" isn't translated properly. It instead uses the whole string.

filter->add_item(String(TTRC("All Recognized")) + " (" + all_filters + ")");

The TTRC has no effect.

Also

filter->add_item(TTRC("All Files (*)"));

should be changed to String(TTRC("All Files")) + " (*)" (but fixed version lol) for consistency.

(The issue is difficult to address right now due to #56945)

Steps to reproduce

  1. Add file dialog
  2. Add some filters
  3. Apply some translation
  4. All is translated except the "All Recognized"

Minimal reproduction project

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant