Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set_locale() has no effect on Control nodes #56945

Closed
KoBeWi opened this issue Jan 19, 2022 · 2 comments · Fixed by #56951
Closed

set_locale() has no effect on Control nodes #56945

KoBeWi opened this issue Jan 19, 2022 · 2 comments · Fixed by #56951
Assignees
@bruvzg
Labels
bug regression topic:core topic:gui
Milestone
4.0

Comments

@KoBeWi
Copy link
Member

KoBeWi commented Jan 19, 2022

Godot version

7a88f5c

System information

W10

Issue description

Seems like Controls no longer auto-translate when locale changes:
godot windows tools 64_N74JEyqnHJ
(for whatever reason it also clears the title of main window)

In 3.x:
godot windows opt tools 64_EUWBl9UB8A

Steps to reproduce

  1. Add control with text
  2. Add translation
  3. Change locale

Minimal reproduction project

LocaleBug.zip
@KoBeWi KoBeWi added this to the 4.0 milestone Jan 19, 2022
@KoBeWi KoBeWi mentioned this issue Jan 19, 2022
Closed
@Zireael07
Copy link
Contributor

3.x has "cig" instead of "ciąg" LOL

@bruvzg bruvzg mentioned this issue Jan 19, 2022
Merged
@Calinou
Copy link
Member

Calinou commented Jan 19, 2022

3.x has "cig" instead of "ciąg" LOL

For reference, this is because the default project font in 3.x has a more limited character set (only basic Latin-1).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bruvzg bruvzg

Labels
bug regression topic:core topic:gui
Projects
None yet
Milestone
4.0
Development

Successfully merging a pull request may close this issue.

Fix locale always selecting translation instead of "en", when no match found. bruvzg/godot
4 participants
@Calinou @KoBeWi @Zireael07 @bruvzg