Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix GLES2 "black" rendering #31062

Merged
merged 1 commit into from
Aug 3, 2019
Merged

Fix GLES2 "black" rendering #31062

merged 1 commit into from
Aug 3, 2019
+14 −14

Conversation

Chaosus
Copy link
Member

@Chaosus Chaosus commented Aug 3, 2019

Fix #31019

@Chaosus Chaosus requested a review from reduz as a code owner August 3, 2019 18:22
@Chaosus Chaosus added this to the 3.2 milestone Aug 3, 2019
@clayjohn
Copy link
Member

clayjohn commented Aug 3, 2019

Note: because this PR only changes stbdlib.glsl shaders will not be rebuilt automatically. For users facing #31019, in order for the fix to work you either need to delete all the *glsl.gen.h files, or you need to do a full git clean build.

@Chaosus Chaosus merged commit e14e08c into godotengine:master Aug 3, 2019
@Chaosus Chaosus deleted the fix_gles2_rendering branch August 3, 2019 18:32
@NeoSpark314 NeoSpark314 mentioned this pull request Aug 3, 2019
Closed
@clayjohn clayjohn mentioned this pull request Mar 22, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clayjohn clayjohn clayjohn approved these changes

@reduz reduz Awaiting requested review from reduz

Assignees
No one assigned
Labels
bug regression topic:rendering
Projects
None yet
Milestone
3.2
Development

Successfully merging this pull request may close these issues.

GLES2 3D editor and game: meshes and viewports are rendered black (no light?)
2 participants
@Chaosus @clayjohn