Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SSAO issue with intel hd**** hardwares #10570

Merged
merged 1 commit into from
Aug 23, 2017

Conversation

groud
Copy link
Member

@groud groud commented Aug 22, 2017

I think there is a problem with cos and sin functions with high values with those hardware. These high values were produced by the hash function used in the shader.

Should fix #9525 and maybe #8708.

\o/

@akien-mga akien-mga added this to the 3.0 milestone Aug 22, 2017
@reduz
Copy link
Member

reduz commented Aug 22, 2017

you are my new hero

@groud
Copy link
Member Author

groud commented Aug 22, 2017

This should be tested however, the result should be similar that with the previous version :)

@groud
Copy link
Member Author

groud commented Aug 23, 2017

I tested how randomPatternRotationAngle is like by setting visibility = cos(randomPatternRotationAngle). It seems pretty random, so I guess I didn't broke the randomization ^^ Cool...

@akien-mga
Copy link
Member

#TestInProduction

@akien-mga akien-mga merged commit 1e55899 into godotengine:master Aug 23, 2017
@groud groud deleted the fix_ssao_issue branch December 26, 2017 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

graphical issues with material_tester demo [MESA, Linux]
3 participants