Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSAO graphical issue with glitchy lines #8708

Closed
honix opened this issue May 10, 2017 · 22 comments
Closed

SSAO graphical issue with glitchy lines #8708

honix opened this issue May 10, 2017 · 22 comments

Comments

@honix
Copy link
Contributor

honix commented May 10, 2017

Operating system or device - Godot version:
OS: Linux Arch 64
Video: Intel HD Graphics 5500
Godot version: Godot 3.0 custom self compiled from 6d0568d

Issue description:
SSAO draws glitchy lines. Camera.Environment with only ssao enabled. Same in editor and game-mode. There is shot without blur:

godot-ssao

@khairul169
Copy link
Contributor

same here on Intel HD 3000

@bojidar-bg bojidar-bg added this to the 3.0 milestone May 10, 2017
@akien-mga akien-mga changed the title [3.0] SSAO graphical issue SSAO graphical issue with glitchy lines May 18, 2017
@akien-mga
Copy link
Member

Does someone reproduce this issue on Windows or macOS?

@Calinou
Copy link
Member

Calinou commented Jun 15, 2017

I can reproduce this on Intel HD Graphics 620 on Windows 10.

Example project

This happens regardless of the SSAO settings used. This bug also does not happen on NVIDIA graphics on Windows 10.

@reduz
Copy link
Member

reduz commented Jun 15, 2017

Same hardware as Calinou, simple can't reproduce :\

@Shockblast
Copy link
Contributor

Notebook HP 340 g1 (Intel Graphics HD 4400) can reproduce
ss

PD: Godot alpha Unofficial Build 13 June in general is extreme slow in notebook (3 FPS approx)

@Calinou
Copy link
Member

Calinou commented Jun 16, 2017

The screenshot above doesn't seem to display artifacts related to SSAO, but rather artifacts related to shadow bias being set to a slightly too low value (a mistake on my side while making the demo project).

PD: Godot alpha Unofficial Build 13 June in general is extreme slow in notebook (3 FPS approx)

More recent builds should be much faster, as the OpenGL error spam was fixed on Intel on Windows.

@Shockblast
Copy link
Contributor

The screenshot above doesn't seem to display artifacts related to SSAO, but rather artifacts related to shadow bias being set to a slightly too low value (a mistake on my side while making the demo project).

wops! (i try same settings from screenshot adove).
ss

@reduz
Copy link
Member

reduz commented Jun 16, 2017 via email

@HummusSamurai
Copy link
Contributor

Does that mean the issue is closed?

@honix
Copy link
Contributor Author

honix commented Jul 5, 2017

I will recheck it today, and post a screenshoot.

@honix
Copy link
Contributor Author

honix commented Jul 5, 2017

Same problem
OS: Linux Arch 64
Video: Intel HD Graphics 5500
Godot version: 3.0 July 4 nightly build
ssao-s
project - ssao-test.zip

@reduz
Copy link
Member

reduz commented Jul 5, 2017 via email

@novemberist
Copy link

novemberist commented Jul 6, 2017

Arch Linux, HD4000 (Mesa 17.1.4) also getting the scanline effect in Calinou's example project (and in the Material Tester demo) but no other glitches. Increasing the SSAO bias setting indeed reduces or removes the effect, but the bias setting shouldn't be hardware/driver specific, should it? Because some people can run the Material Tester demo without the scanline effect and tweaking the bias setting.

@honix Could you please upload your example project? I would like to try if I also get the glitchy lines.

[edit] nevermind, i didn't see the link ;)
[edit2]

I can also reproduce the red lines from honix' example. I don't have them in the editor, though, but only when actually running the scene. Would be nice to have someone with the same hardware, but an older version of mesa to test this (any Debian users here?)

Don't know if this is helpfull, but this is how the SSAo bias setting affects the issue:
bias

@groud
Copy link
Member

groud commented Aug 23, 2017

Should be fixed in current master. Could you check that ?

@novemberist
Copy link

novemberist commented Aug 23, 2017

Looks fine now on my HD4000. Let's see if it's also fixed for other intel gpus.

ssao_artifacts

@akien-mga
Copy link
Member

Are those red clouds of dots expected though?

@novemberist
Copy link

novemberist commented Aug 23, 2017

I think @honix used these exaggerated ssao settings (and the red color) on purpose in his example project for better visualization of the issue.

@groud
Copy link
Member

groud commented Aug 23, 2017

Are those red clouds of dots expected though?

I'm not the expert but I'd say yes. The really low value for the bias may cause that.

@himaghnam
Copy link

himaghnam commented Aug 23, 2017

ssao colour was changed here , blur option was turned off(blur has no slider) to have such ssao output

@honix
Copy link
Contributor Author

honix commented Aug 23, 2017

Hm.. Can't build master or 591a892 to test. Maybe there is some working builds?

editor/editor_icons.cpp:1:10: fatal error: editor_icons.h: No such file or directory

@akien-mga
Copy link
Member

@honix Run git clean -fX to remove your build artifacts and start from scratch.

@honix
Copy link
Contributor Author

honix commented Aug 23, 2017

@akien-mga fresh git clone do the job.

ssao-fixed
@ Intel HD Graphics 5500

It looks good for me. Blur option successfully reduces this noise.

I think issue is closed!

@honix honix closed this as completed Aug 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests