Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make selected keyframes more visually distinctive from unselected ones and easier to select. #27276

Closed
golddotasksquestions opened this issue Mar 20, 2019 · 2 comments · Fixed by #31081

Comments

@golddotasksquestions
Copy link

Godot version:
3.1

Keyframes are hard to select because their "hitbox" is tiny and selected keys are visually hard to read and there is no audio feedback.

Proposal:

  • Increase the size of selected keyframes slightly (maybe +1 pixel in each direction is sufficient),
  • change the color of selected keyframes to something bright, or have a soft glow around them.
  • play a soft unintrusive short sound when selecting a keyframe, it can be hardly audible, but your body will immediately know when miss-clicked even if you where not looking.
@regakakobigman
Copy link

I don't think the editor has any sounds currently. I'd rather keep it silent, unless the rest of the interface was given optional sound cues.

I agree with the other two suggestions, though. The Poly Editor has an adjustable point grab radius in the settings. What if keyframes had an adjustable grab radius and visual size in the settings, under Editors\Animation?

@golddotasksquestions
Copy link
Author

golddotasksquestions commented Mar 22, 2019

Sound could be entirely optional, and easy to tick on or off globally in the preferences. There has to be some kind of feedback for the user when a operation is unsuccessful, or rather invalid, though. Currently there is none, and not just in the AnimationPlayer. This is an issue throughout the engine. I often do something, it seems to have no effect, but I am not entirely sure, but have to proceide. And I cannot even check in the undo history log, because Godot has no history log to check. (#25919).

Calinou added a commit to Calinou/godot that referenced this issue Aug 4, 2019
Keyframe SVG icons are now 10×10 instead of 8×8 (except for
Bezier-related icons). This makes them easier to select
since the empty space is part of the clickable area.

Selected keyframes are now also visually larger to make them
easier to distinguish from unselected keyframes.

This closes godotengine#27276.
myhalibobo pushed a commit to myhalibobo/godot that referenced this issue Sep 3, 2019
Keyframe SVG icons are now 10×10 instead of 8×8 (except for
Bezier-related icons). This makes them easier to select
since the empty space is part of the clickable area.

Selected keyframes are now also visually larger to make them
easier to distinguish from unselected keyframes.

This closes godotengine#27276.
pchasco pushed a commit to pchasco/godot that referenced this issue Oct 23, 2019
Keyframe SVG icons are now 10×10 instead of 8×8 (except for
Bezier-related icons). This makes them easier to select
since the empty space is part of the clickable area.

Selected keyframes are now also visually larger to make them
easier to distinguish from unselected keyframes.

This closes godotengine#27276.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants